Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onetbb : Add provides tbb. #19532

Closed

Conversation

p-groarke
Copy link

Specify library name and version: onetbb/*

Allows overriding packages that use deprecated tbb with onetbb.
provides docs : https://docs.conan.io/1/reference/conanfile/attributes.html#provides
Submitting because I have to override a package that wants tbb with onetbb.


Allows overriding packages that use deprecated tbb with onetbb.
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.


Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@ghost
Copy link

ghost commented Aug 31, 2023

I detected other pull requests that are modifying onetbb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 31, 2023

AFAIK, provides doesn't achieve what you want (allow conan to happily replace tbb by onetbb in dependency graph of recipes which would still refer to tbb). There is already a deprecated attribute in tbb recipe, so no reason to add a provides in onetbb.

Why don't you just update these recipes to depend on onetbb instead of tbb?

@p-groarke
Copy link
Author

It does work.
I don't control the other recipes.

@p-groarke
Copy link
Author

@SpaceIm Your casting doubt on whether it works. IIRC it works, but i'll double check a test project. We probably want this anyhow since mixing tbb and onetbb is a no-no, but if you think its a bad idea i'll close.

@p-groarke
Copy link
Author

I must have been hallucinating, it doesn't work.

@p-groarke p-groarke closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants