Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onetbb: require conan 2.0.8 because of 'cmake_config_version_compat' #19235

Closed
wants to merge 1 commit into from

Conversation

ilya-lavrenov
Copy link
Contributor

Specify library name and version: onetbb/2021.9.0

See conan-io/conan#13809
Without increasing Conan minimal version, this option has no effect


@ghost
Copy link

ghost commented Aug 16, 2023

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 17, 2023

It seems excessive. cmake_config_version_compat is no-op with with conan < 2.0.8, and it doesn't matter for most people.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (e07f2dcc0b1636ddfaa4382ac9ba32da9cffbf4a):

  • onetbb/2021.7.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.9.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.8.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.6.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.3.0@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 1 (e07f2dcc0b1636ddfaa4382ac9ba32da9cffbf4a):

  • onetbb/2021.6.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.8.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.9.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.7.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.3.0@:
    All packages built successfully! (All logs)

@jcar87
Copy link
Contributor

jcar87 commented Aug 21, 2023

Without increasing Conan minimal version, this option has no effect

I think there may be a misunderstanding - the option has an effect for users on Conan version 2.0.8 or higher, irrespective of the required_conan_version value in the recipe. By increasing it to required_conan_version this would force everyone using Conan 2.0 to be on at least that version, when it's not technically required. find_package(TBB X.Y) specifying a version will only work for users on Conan >= 2.0.8 and a recent recipe revision, but find_package(TBB) should work for everyone.

@AbrilRBS
Copy link
Member

Closing, as @jcar87 and @SpaceIm pointed out, requiring >=2.0.8 is excessive in this case :)

@AbrilRBS AbrilRBS closed this Aug 28, 2023
@ilya-lavrenov ilya-lavrenov deleted the onetbb branch August 29, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants