vsg ImGui integration #18965

psyinf · 2023-07-29T21:33:52Z

vsgImGui 0.1.0

Add-on for vsg(VulkanSceneGraph) to integrate imgui

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

recipes/vsgimgui/all/conanfile.py

czoido · 2023-08-30T07:20:46Z

recipes/vsgimgui/all/conanfile.py

+        tc.variables["VSG_MACRO_PATH"] = os.path.join(self.deps_cpp_info["vsg"].rootpath, "lib/cmake/vsg/").replace("\\","/")
+


I think this probably should be handled in the vsg recipe adding the macro, something like:

self.cpp_info.set_property("cmake_build_modules", [os.path.join("lib", "cmake", "vsg", "vsgMacros.cmake")])

recipes/vsgimgui/all/conanfile.py

czoido · 2023-08-30T07:45:29Z

recipes/vsgimgui/all/conanfile.py

+        self.requires("vsg/[>1.0.5]")
+        self.requires("imgui/1.89.5")
+        self.requires("implot/0.14")


Suggested change

self.requires("vsg/[>1.0.5]")

self.requires("imgui/1.89.5")

self.requires("implot/0.14")

self.requires("vsg/1.0.5", transitive_headers=True)

self.requires("imgui/1.89.8", transitive_headers=True)

self.requires("implot/0.16")

czoido · 2023-08-30T07:45:56Z

recipes/vsgimgui/all/conanfile.py

+        if is_msvc(self):
+            tc.variables["USE_MSVC_RUNTIME_LIBRARY_DLL"] = not is_msvc_static_runtime(self)
+
+        tc.variables["VSG_MACRO_PATH"] = os.path.join(self.deps_cpp_info["vsg"].rootpath, "lib/cmake/vsg/").replace("\\","/")


Suggested change

tc.variables["VSG_MACRO_PATH"] = os.path.join(self.deps_cpp_info["vsg"].rootpath, "lib/cmake/vsg/").replace("\\","/")

recipes/vsgimgui/all/conanfile.py

czoido · 2023-08-30T07:47:15Z

recipes/vsgimgui/all/patches/0.1.0-0001-includeMacro.patch

+ endif()
+
+ find_package(vsg 1.0.5)
+include(${VSG_MACRO_PATH}/vsgMacros.cmake)


This should not be necessary if we declare cmake_build_modules property in vsg for that macro

I'll update the vsg package and then re-integrate this

stale · 2023-10-15T10:07:38Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

conan-center-bot · 2023-10-16T20:47:46Z

Conan v1 pipeline ❌

Failure in build 8 (defa690909adb74ec196439a6516c69f17266534):

vsgimgui/0.1.0:
CI failed to create some packages (All logs)

Logs for packageID 3d0cd7dfe37957a4581f56050b1abaeb26581eb7:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=10
os=Linux
[options]
vsgimgui:shared=False

[...]
dpkg-query: no packages found matching libx11-xcb-dev
dpkg-query: no packages found matching libfontenc-dev
dpkg-query: no packages found matching libice-dev
dpkg-query: no packages found matching libsm-dev
dpkg-query: no packages found matching libxau-dev
dpkg-query: no packages found matching libxaw7-dev
dpkg-query: no packages found matching libxcomposite-dev
dpkg-query: no packages found matching libxcursor-dev
dpkg-query: no packages found matching libxdamage-dev
dpkg-query: no packages found matching libxdmcp-dev
dpkg-query: no packages found matching libxext-dev
dpkg-query: no packages found matching libxfixes-dev
dpkg-query: no packages found matching libxi-dev
dpkg-query: no packages found matching libxinerama-dev
dpkg-query: no packages found matching libxkbfile-dev
dpkg-query: no packages found matching libxmu-dev
dpkg-query: no packages found matching libxmuu-dev
dpkg-query: no packages found matching libxpm-dev
dpkg-query: no packages found matching libxrandr-dev
dpkg-query: no packages found matching libxrender-dev
dpkg-query: no packages found matching libxres-dev
dpkg-query: no packages found matching libxss-dev
dpkg-query: no packages found matching libxt-dev
dpkg-query: no packages found matching libxtst-dev
dpkg-query: no packages found matching libxv-dev
dpkg-query: no packages found matching libxvmc-dev
dpkg-query: no packages found matching libxxf86vm-dev
dpkg-query: no packages found matching libxcb-render0-dev
dpkg-query: no packages found matching libxcb-render-util0-dev
dpkg-query: no packages found matching libxcb-xkb-dev
dpkg-query: no packages found matching libxcb-icccm4-dev
dpkg-query: no packages found matching libxcb-image0-dev
dpkg-query: no packages found matching libxcb-keysyms1-dev
dpkg-query: no packages found matching libxcb-randr0-dev
dpkg-query: no packages found matching libxcb-shape0-dev
dpkg-query: no packages found matching libxcb-sync-dev
dpkg-query: no packages found matching libxcb-xfixes0-dev
dpkg-query: no packages found matching libxcb-xinerama0-dev
dpkg-query: no packages found matching libxcb-dri3-dev
dpkg-query: no packages found matching uuid-dev
dpkg-query: no packages found matching libxcb-cursor-dev
debconf: delaying package configuration, since apt-utils is not installed
dpkg-query: no packages found matching libxcb-util-dev
debconf: delaying package configuration, since apt-utils is not installed
WARN: implot/0.16: requirement imgui/1.89.9 overridden by vsgimgui/0.1.0 to imgui/1.89.8 
vsgimgui/0.1.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
vsgimgui/0.1.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
[HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared `cpp_info` information (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016-CMAKE-MODULES-CONFIG-FILES) 
[HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files: ./lib/cmake/vsgImGui/vsgImGuiConfig.cmake (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016-CMAKE-MODULES-CONFIG-FILES) 
ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 7 (defa690909adb74ec196439a6516c69f17266534):

vsgimgui/0.1.0:
Error running command

conan graph info --requires vsgimgui/0.1.0@#de003a306329b94e5a926450c3078818 -f json  -pr:h /home/conan/w/prod-v2/bsr/23558/dbecf/profile_linux_11_libstdcpp11_17_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2/bsr/23558/dbecf/profile_linux_11_libstdcpp11_17_gcc_release_64..txt

:

======== Computing dependency graph ========
vulkan-loader/1.3.239.0: Not found in local cache, looking in remotes...
vulkan-loader/1.3.239.0: Checking remote: conan-center
vulkan-loader/1.3.239.0: Downloaded recipe revision f4addab2eb9f793087a3dfc9d16a91e2
vulkan-headers/1.3.239.0: Not found in local cache, looking in remotes...
vulkan-headers/1.3.239.0: Checking remote: conan-center
vulkan-headers/1.3.239.0: Downloaded recipe revision 3f678623fcd7aa3a39015b5770f4f31d
xorg/system: Not found in local cache, looking in remotes...
xorg/system: Checking remote: conan-center
xorg/system: Downloaded recipe revision de8fc1917bb3d11cf7a1d15eccf79c16
pkgconf/1.9.3: Not found in local cache, looking in remotes...
pkgconf/1.9.3: Checking remote: conan-center
pkgconf/1.9.3: Downloaded recipe revision 3e658ebc066dc868a1f8a472c1065368
meson/1.2.2: Not found in local cache, looking in remotes...
meson/1.2.2: Checking remote: conan-center
meson/1.2.2: Downloaded recipe revision aace9dcc1db58fa42ecb5292f724092d
ninja/1.11.1: Not found in local cache, looking in remotes...
ninja/1.11.1: Checking remote: conan-center
ninja/1.11.1: Downloaded recipe revision 77587f8c8318662ac8e5a7867eb4be21
cmake/3.27.7: Not found in local cache, looking in remotes...
cmake/3.27.7: Checking remote: conan-center
cmake/3.27.7: Downloaded recipe revision 6e11610a238b9292dffda14c34bb53e6
vsg/1.0.9: Not found in local cache, looking in remotes...
vsg/1.0.9: Checking remote: conan-center
vsg/1.0.9: Downloaded recipe revision 16075e10184e4b9ac71f54e558228d8d
imgui/1.89.8: Not found in local cache, looking in remotes...
imgui/1.89.8: Checking remote: conan-center
imgui/1.89.8: Downloaded recipe revision 3db675fa3f86e6c64d41909d18ec0eba
implot/0.16: Not found in local cache, looking in remotes...
implot/0.16: Checking remote: conan-center
implot/0.16: Downloaded recipe revision 3a51885b13ee0bf6ae8dfce91dc409eb
Graph root
    cli
Requirements
    imgui/1.89.8#3db675fa3f86e6c64d41909d18ec0eba - Downloaded (conan-center)
    implot/0.16#3a51885b13ee0bf6ae8dfce91dc409eb - Downloaded (conan-center)
    vsg/1.0.9#16075e10184e4b9ac71f54e558228d8d - Downloaded (conan-center)
    vsgimgui/0.1.0#de003a306329b94e5a926450c3078818 - Cache
    vulkan-headers/1.3.239.0#3f678623fcd7aa3a39015b5770f4f31d - Downloaded (conan-center)
    vulkan-loader/1.3.239.0#f4addab2eb9f793087a3dfc9d16a91e2 - Downloaded (conan-center)
    xorg/system#de8fc1917bb3d11cf7a1d15eccf79c16 - Downloaded (conan-center)
Build requirements
    cmake/3.27.7#6e11610a238b9292dffda14c34bb53e6 - Downloaded (conan-center)
    meson/1.2.2#aace9dcc1db58fa42ecb5292f724092d - Downloaded (conan-center)
    ninja/1.11.1#77587f8c8318662ac8e5a7867eb4be21 - Downloaded (conan-center)
    pkgconf/1.9.3#3e658ebc066dc868a1f8a472c1065368 - Downloaded (conan-center)
Resolved version ranges
    cmake/[>=3.17.2 <4.0]: cmake/3.27.7
    vsg/[>1.0.5]: vsg/1.0.9
Graph error
    Version conflict: Conflict between imgui/1.89.9 and imgui/1.89.8 in the graph.
Conflict originates from implot/0.16

Run conan graph info with your recipe and add --format=html to inspect the graph errors in an easier to visualize way.
ERROR: Version conflict: Conflict between imgui/1.89.9 and imgui/1.89.8 in the graph.
Conflict originates from implot/0.16

Run conan graph info with your recipe and add --format=html to inspect the graph errors in an easier to visualize way.

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

github-actions · 2024-06-14T06:37:38Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2024-07-21T06:37:52Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

conan-center-bot added the Service Under Maintenance label Jul 29, 2023

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Jul 29, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

psyinf changed the title ~~Vsg im gui~~ vsg ImGui integration Jul 31, 2023

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Service Under Maintenance labels Aug 5, 2023

This comment has been minimized.

Sign in to view

czoido self-assigned this Aug 18, 2023

czoido reviewed Aug 18, 2023

View reviewed changes

recipes/vsgimgui/all/conanfile.py Outdated Show resolved Hide resolved

czoido reviewed Aug 18, 2023

View reviewed changes

recipes/vsgimgui/all/conanfile.py Outdated Show resolved Hide resolved

czoido reviewed Aug 18, 2023

View reviewed changes

recipes/vsgimgui/all/conanfile.py Outdated Show resolved Hide resolved

czoido reviewed Aug 30, 2023

View reviewed changes

recipes/vsgimgui/all/conanfile.py Outdated Show resolved Hide resolved

czoido reviewed Aug 30, 2023

View reviewed changes

recipes/vsgimgui/all/conanfile.py Show resolved Hide resolved

czoido reviewed Aug 30, 2023

View reviewed changes

stale bot added stale and removed stale labels Oct 15, 2023

psyinf and others added 8 commits October 16, 2023 20:34

initial vsgimgui, currently failing

b207bca

corrected version and included vulkan_impl

33e2b22

Update conandata.yml conformity

d980d45

Update conanfile.py for conformity

437ce4b

corrected vsg dependency

1994d6a

Update recipes/vsgimgui/all/conanfile.py

1402b65

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

Apply suggestions from code review

cbea599

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

re-added >1.0.5 and bumped dependencies

defa690

psyinf force-pushed the vsgImGui branch from 90322cb to defa690 Compare October 16, 2023 18:34

github-actions bot added the stale label Jun 14, 2024

ErniGH mentioned this pull request Jun 14, 2024

Prioritization of new recipe PRs #24327

Open

github-actions bot closed this Jul 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vsg ImGui integration #18965

vsg ImGui integration #18965

psyinf commented Jul 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

czoido Aug 30, 2023

czoido Aug 30, 2023

czoido Aug 30, 2023

czoido Aug 30, 2023

psyinf Oct 16, 2023

stale bot commented Oct 15, 2023

conan-center-bot commented Oct 16, 2023

github-actions bot commented Jun 14, 2024

github-actions bot commented Jul 21, 2024

		tc.variables["VSG_MACRO_PATH"] = os.path.join(self.deps_cpp_info["vsg"].rootpath, "lib/cmake/vsg/").replace("\\","/")

vsg ImGui integration #18965

vsg ImGui integration #18965

Conversation

psyinf commented Jul 29, 2023

Add-on for vsg(VulkanSceneGraph) to integrate imgui

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

czoido Aug 30, 2023

Choose a reason for hiding this comment

czoido Aug 30, 2023

Choose a reason for hiding this comment

czoido Aug 30, 2023

Choose a reason for hiding this comment

czoido Aug 30, 2023

Choose a reason for hiding this comment

psyinf Oct 16, 2023

Choose a reason for hiding this comment

stale bot commented Oct 15, 2023

conan-center-bot commented Oct 16, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

github-actions bot commented Jun 14, 2024

github-actions bot commented Jul 21, 2024