Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isa-l: migrate to Conan v2 #18955

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 28, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the migrate/isa-l branch 2 times, most recently from 7f8c307 to 6f1d32c Compare August 3, 2023 06:25
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@@ -1,4 +1,7 @@
sources:
"cci.20230818":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding this version? Is there a request for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but the latest release was 3 years ago. Tbh, I don't remember any more details about why I chose to add it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather leave it until someone requests an updated version in an issue or similar to avoid creating kind of artificial versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I agree. Will revert this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😄

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (de1c136b3989d239273b57528ad3852d980f7963):

  • isa-l/2.30.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (de1c136b3989d239273b57528ad3852d980f7963):

  • isa-l/2.30.0:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit de1c136
isa-l/2.30.0@#dd29955a96d88e6cfbd6001212e14e3c
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisal.2.dylib, libisal.dylib

@conan-center-bot conan-center-bot merged commit af1d897 into conan-io:master Dec 5, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants