Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cctag/1.0.3 #18631

Conversation

EstebanDugueperoux2
Copy link
Contributor

Specify library name and version: cctag/1.0.3


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@EstebanDugueperoux2
Copy link
Contributor Author

Depends of #18625 to have pipeline v2 works.

@conan-center-bot

This comment has been minimized.

@EstebanDugueperoux2
Copy link
Contributor Author

Hi @ericLemanissier , @prince-chrismc, @SpaceIm could you review this PR?

@ghost
Copy link

ghost commented Jul 20, 2023

I detected other pull requests that are modifying cctag/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Contributor

@ericLemanissier ericLemanissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch does not seem needed, and could make the situation more confusing than needed if somehow the version of TBB is overriden duing the build of cctag

Comment on lines 1 to 12
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -241,7 +241,7 @@ endif()
# FIND Intel TBB
# With MVSC, CMAKE_BUILD_TYPE will always be None, so TBB_USE_DEBUG_BUILD will always be false.
string(COMPARE EQUAL "${CMAKE_BUILD_TYPE}" Debug TBB_USE_DEBUG_BUILD)
-find_package(TBB 2021.5.0 CONFIG REQUIRED)
+find_package(TBB CONFIG REQUIRED)
message(STATUS "Found TBB: version ${TBB_VERSION}")

add_subdirectory(src)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -241,7 +241,7 @@ endif()
# FIND Intel TBB
# With MVSC, CMAKE_BUILD_TYPE will always be None, so TBB_USE_DEBUG_BUILD will always be false.
string(COMPARE EQUAL "${CMAKE_BUILD_TYPE}" Debug TBB_USE_DEBUG_BUILD)
-find_package(TBB 2021.5.0 CONFIG REQUIRED)
+find_package(TBB CONFIG REQUIRED)
message(STATUS "Found TBB: version ${TBB_VERSION}")
add_subdirectory(src)

Comment on lines 9 to 12
"1.0.3":
- patch_file: "patches/0001-Ignore-TBB-version.patch"
patch_description: "Ignore TBB version in find_package to consume one from conan"
patch_type: "conan"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"1.0.3":
- patch_file: "patches/0001-Ignore-TBB-version.patch"
patch_description: "Ignore TBB version in find_package to consume one from conan"
patch_type: "conan"

@EstebanDugueperoux2
Copy link
Contributor Author

This patch does not seem needed, and could make the situation more confusing than needed if somehow the version of TBB is overriden duing the build of cctag

Indeed but the issue is onetbb/2021.5.0 is not available on conan center.
Then I must before add it to conan center to reference it in this recipe, and perhaps add a validation rule to forbidden the onetbb/2021.5.0 requirement override.

@ericLemanissier
Copy link
Contributor

ow, so cmake does not consider 2021.6.0 compatible with 2021.5.0 ? ok then

@EstebanDugueperoux2
Copy link
Contributor Author

ow, so cmake does not consider 2021.6.0 compatible with 2021.5.0 ? ok then

It seems that TBB does not follow semantic versionning.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (02aac5ca125d4fdf5c038cce96329c9b9feab169):

  • cctag/1.0.3:
    All packages built successfully! (All logs)

  • cctag/1.0.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 11 (02aac5ca125d4fdf5c038cce96329c9b9feab169):

  • cctag/1.0.3:
    Error running command conan graph info --requires cctag/1.0.3@#98921aaca199edc5b7835a6a0433f467 -f json -pr:h /home/conan/w/prod-v2_cci_PR-18631/11/37f5d1bd-45aa-4e84-92a9-bb7c8cd6db20/profile_osx_13_libcpp_17_apple-clang_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-18631/11/37f5d1bd-45aa-4e84-92a9-bb7c8cd6db20/profile_osx_13_libcpp_17_apple-clang_release_64..txt:
    ======== Computing dependency graph ========
    Graph root
        cli
    Requirements
        ade/0.1.2a#b569ff943843abd004e65536e265a445 - Cache
        boost/1.71.0#b5d1866fc8150c88337fa647398a3c93 - Cache
        brotli/1.0.9#ffbecf553112bc3e25a08c91c28b8b68 - Cache
        bzip2/1.0.8#411fc05e80d47a89045edc1ee6f23c1d - Cache
        cctag/1.0.3#98921aaca199edc5b7835a6a0433f467 - Cache
        eigen/3.4.0#2e192482a8acff96fe34766adca2b24c - Cache
        ffmpeg/4.4.3#cfdf2776bd08a4bfbf13104ceacc1c5f - Cache
        freetype/2.13.0#1c9d3ee5f24ec350675b8e1d13a5646f - Cache
        imath/3.1.9#ff1999f4d4a6885b68a84d0b039a5847 - Cache
        jasper/4.0.0#c2a1cfb970fd5f28ad99880d0735776a - Cache
        jbig/20160605#2d29fa02aacd76902e0d2cbbc24631ef - Cache
        libbacktrace/cci.20210118#ec1aa63bbc10145c6a299e68e711670c - Cache
        libdeflate/1.18#3697b637656a9af04cabcbed50db9a7e - Cache
        libfdk_aac/2.0.2#c9eb99853a2067c754bb1a826044d6eb - Cache
        libiconv/1.17#fa54397801cd96911a8294bc5fc76335 - Cache
        libjpeg/9e#68269859e4325ddc3f995d1fd3fc9187 - Cache
        libmp3lame/3.100#44b12d19316eb2b223d98d3e75dae438 - Cache
        libpng/1.6.40#3b63a2aa000933a57a53322207790714 - Cache
        libtiff/4.5.1#fe513220cfef719a8a92caadd9afa1b8 - Cache
        libvpx/1.11.0#6fbd55b629d52b82db5786b0dd84a48b - Cache
        libwebp/1.3.1#f86c9ecf081ebd5ac9def27e53de7bd3 - Cache
        libx264/cci.20220602#1847939486c0bfc5141898c469f9fff4 - Cache
        libx265/3.4#fb1af2d1f0f1c8aa25510237f1d86c39 - Cache
        ogg/1.3.5#062626875f5c8c59f069f76f148098ef - Cache
        onetbb/2021.6.0#a11b079b43b0745c1cbebc99f2a1299b - Cache
        opencv/4.5.5#0b8ec748c4409d398fbe0cf0e0bc3f8a - Cache
        openexr/3.1.9#b3463fd75d4bec8a4ffe9e8205b88e70 - Cache
        openh264/2.3.1#8b94a94f5472b67355953c7748ad4381 - Cache
        openjpeg/2.5.0#e3684ea8ab1cfc6707a461b0b2d0bb9c - Cache
        openssl/3.1.2#87b69c377d7931544211fbdab893893a - Cache
        opus/1.3.1#9215b71ae0360515fffc660a7b153ddd - Cache
        protobuf/3.21.12#d9f5f4e3b86552552dda4c0a2e928eeb - Cache
        quirc/1.2#92179dd521786aea0729f2c859cbbcb9 - Cache
        vorbis/1.3.7#d936fd8c850f0c7c4021e24e55e6352c - Cache
        xz_utils/5.4.2#b6ee8320403def553418874435445982 - Cache
        zlib/1.2.13#e377bee636333ae348d51ca90874e353 - Cache
        zstd/1.5.5#93372fe14bb7883bd4de82914e0a1841 - Cache
    Build requirements
        b2/4.9.6#53783bdbbdbb6c13732b25f1f6ea6c58 - Cache
        cmake/3.27.1#7d5f14447c023feef9f59640be53619a - Cache
        gnu-config/cci.20210814#15c3bf7dfdb743977b84d0321534ad90 - Cache
        meson/1.0.0#15586c0ac6f682805875ef903dbe7ee2 - Cache
        nasm/2.15.05#799d63b1672a337584b09635b0f22fc1 - Cache
        ninja/1.11.1#77587f8c8318662ac8e5a7867eb4be21 - Cache
        pkgconf/1.9.3#5da3944c3226f5764374e4b8b4e1d055 - Cache
        yasm/1.3.0#fb800a15413dca19bfaef9e4b5d50694 - Cache
    Resolved version ranges
        cmake/[>=3.18 <4]: cmake/3.27.1
        openssl/[>=1.1 <4]: openssl/3.1.2
    
    ======== Computing necessary packages ========
    libfdk_aac/2.0.2: Checking 11 compatible configurations:
    libfdk_aac/2.0.2: '26cdf99ba3ed6501c46f5e43ed8ef397d442d402': compiler.cppstd=98
    libfdk_aac/2.0.2: 'bde82464870a3362a84c3c5d1dd4094fdd4b1bfd': compiler.cppstd=gnu98
    libfdk_aac/2.0.2: 'c67bcf232eb9e5794e89729e04998bef9b19eefb': compiler.cppstd=11
    libfdk_aac/2.0.2: 'f6fea12bf0c10722bda5ac1345ff9c98f47301a2': compiler.cppstd=gnu11
    libfdk_aac/2.0.2: 'c0f853c25cc5d100d304a70f70d817d787e606c2': compiler.cppstd=14
    libfdk_aac/2.0.2: 'bf3423a671dcc04e7362805a7576c325c1d39120': compiler.cppstd=gnu14
    libfdk_aac/2.0.2: 'de9831d946d78d4bac4951fac08e31bd50880567': compiler.cppstd=gnu17
    ERROR: HTTPSConnectionPool(host='c3i.jfrog.io', port=443): Max retries exceeded with url: /c3i/api/conan/conan-center/v2/conans/libfdk_aac/2.0.2/_/_/revisions/c9eb99853a2067c754bb1a826044d6eb/packages/de9831d946d78d4bac4951fac08e31bd50880567/latest (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7f92b2a15b10>, 'Connection to c3i.jfrog.io timed out. (connect timeout=30)'))
    
    Unable to connect to conan-center=https://c3i.jfrog.io/c3i/api/conan/conan-center
    1. Make sure the remote is reachable or,
    2. Disable it by using conan remote disable,
    Then try again.
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@EstebanDugueperoux2
Copy link
Contributor Author

Hi @jcar87 , hi @prince-chrismc do you have an idea of what occurred in my pipeline?

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants