-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cctag/1.0.3 #18631
Add cctag/1.0.3 #18631
Conversation
c05552e
to
50011c7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
29bdce8
to
1fc2a49
Compare
This comment has been minimized.
This comment has been minimized.
1fc2a49
to
e6edea8
Compare
This comment has been minimized.
This comment has been minimized.
e6edea8
to
78010eb
Compare
This comment has been minimized.
This comment has been minimized.
78010eb
to
3541d8f
Compare
Depends of #18625 to have pipeline v2 works. |
This comment has been minimized.
This comment has been minimized.
Hi @ericLemanissier , @prince-chrismc, @SpaceIm could you review this PR? |
I detected other pull requests that are modifying cctag/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch does not seem needed, and could make the situation more confusing than needed if somehow the version of TBB is overriden duing the build of cctag
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -241,7 +241,7 @@ endif() | ||
# FIND Intel TBB | ||
# With MVSC, CMAKE_BUILD_TYPE will always be None, so TBB_USE_DEBUG_BUILD will always be false. | ||
string(COMPARE EQUAL "${CMAKE_BUILD_TYPE}" Debug TBB_USE_DEBUG_BUILD) | ||
-find_package(TBB 2021.5.0 CONFIG REQUIRED) | ||
+find_package(TBB CONFIG REQUIRED) | ||
message(STATUS "Found TBB: version ${TBB_VERSION}") | ||
|
||
add_subdirectory(src) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- a/CMakeLists.txt | |
+++ b/CMakeLists.txt | |
@@ -241,7 +241,7 @@ endif() | |
# FIND Intel TBB | |
# With MVSC, CMAKE_BUILD_TYPE will always be None, so TBB_USE_DEBUG_BUILD will always be false. | |
string(COMPARE EQUAL "${CMAKE_BUILD_TYPE}" Debug TBB_USE_DEBUG_BUILD) | |
-find_package(TBB 2021.5.0 CONFIG REQUIRED) | |
+find_package(TBB CONFIG REQUIRED) | |
message(STATUS "Found TBB: version ${TBB_VERSION}") | |
add_subdirectory(src) |
recipes/cctag/all/conandata.yml
Outdated
"1.0.3": | ||
- patch_file: "patches/0001-Ignore-TBB-version.patch" | ||
patch_description: "Ignore TBB version in find_package to consume one from conan" | ||
patch_type: "conan" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"1.0.3": | |
- patch_file: "patches/0001-Ignore-TBB-version.patch" | |
patch_description: "Ignore TBB version in find_package to consume one from conan" | |
patch_type: "conan" |
Indeed but the issue is onetbb/2021.5.0 is not available on conan center. |
ow, so cmake does not consider 2021.6.0 compatible with 2021.5.0 ? ok then |
It seems that TBB does not follow semantic versionning. |
3541d8f
to
6a9b1c0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6a9b1c0
to
cbad8ca
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f3525dc
to
041e141
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
abd1877
to
474a444
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
474a444
to
2f0ae42
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hi @jcar87 , hi @prince-chrismc do you have an idea of what occurred in my pipeline? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Specify library name and version: cctag/1.0.3