-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libnghttp2 #173
Add libnghttp2 #173
Conversation
|
||
def _build_with_autotools(self): | ||
if self.options.with_app: | ||
os.rename('c-ares.pc', 'libcares.pc') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these pkg-config coming from? Should this recipe us the pkg_config
generator for this with_app
option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like that the name for the c-ares
library should be libcares
so Conan generates the proper .pc
file. Or we should use the components feature to give it a different name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have cppinfo.name
, that should be enough, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, this is not an issue of this recipe, but the c-ares
one
libnghttp2/1.39.2:
|
Some configurations of 'libnghttp2/1.39.2' have failed:
|
Some configurations of 'libnghttp2/1.39.2' have failed:
|
All green! 😊
|
All green! 😊
|
recipes/nghttp2/all/conanfile.py
Outdated
@@ -7,7 +7,7 @@ | |||
|
|||
|
|||
class Nghttp2Conan(ConanFile): | |||
name = "nghttp2" | |||
name = "libnghttp2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgsogo What was the motivation for this? The project calls itself nghttp2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember right now 😓 Several options come to my mind: Windows or something related to libcurl
consuming this recipe (https://github.com/jgsogo/conan-center-index/tree/recipe/libcurl/recipes/libcurl). Tomorrow I will have a look at libcurl
and hope I will realize about it.
libnghttp2/1.39.2
Recipe taken from https://github.com/bincrafters/conan-nghttp2
conan-center hook activated.