Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libnghttp2 #173

Merged
merged 6 commits into from
Oct 24, 2019
Merged

Add libnghttp2 #173

merged 6 commits into from
Oct 24, 2019

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Oct 3, 2019

libnghttp2/1.39.2

Recipe taken from https://github.com/bincrafters/conan-nghttp2


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@jgsogo jgsogo changed the title Recipe/nghttp2 Add libnghttp2 Oct 3, 2019
recipes/libnghttp2/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libnghttp2/all/conanfile.py Outdated Show resolved Hide resolved

def _build_with_autotools(self):
if self.options.with_app:
os.rename('c-ares.pc', 'libcares.pc')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these pkg-config coming from? Should this recipe us the pkg_config generator for this with_app option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that the name for the c-ares library should be libcares so Conan generates the proper .pc file. Or we should use the components feature to give it a different name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have cppinfo.name, that should be enough, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, this is not an issue of this recipe, but the c-ares one

recipes/libnghttp2/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

libnghttp2/1.39.2:

  • Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++ . Options: libnghttp2:shared:True
    You are depending on 'libxml2/2.9.9' but it is not in the repository

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libnghttp2/1.39.2' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libnghttp2:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [META LINES (KB-H025)] Shebang (#!) detected in your recipe. Remove the line 1 (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H025)
      • [HOOK - conan-center.py] pre_export(): ERROR: [META LINES (KB-H025)] PEP 263 (encoding) is not allowed in the conanfile. Remove the line 2 (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H025)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libnghttp2/1.39.2' have failed:

@conan-center-bot
Copy link
Collaborator

All green! 😊

@jgsogo jgsogo marked this pull request as ready for review October 23, 2019 15:21
@conan-center-bot
Copy link
Collaborator

All green! 😊

@lasote lasote merged commit f3ab6d4 into conan-io:master Oct 24, 2019
@@ -7,7 +7,7 @@


class Nghttp2Conan(ConanFile):
name = "nghttp2"
name = "libnghttp2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgsogo What was the motivation for this? The project calls itself nghttp2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember right now 😓 Several options come to my mind: Windows or something related to libcurl consuming this recipe (https://github.com/jgsogo/conan-center-index/tree/recipe/libcurl/recipes/libcurl). Tomorrow I will have a look at libcurl and hope I will realize about it.

@jgsogo jgsogo deleted the recipe/nghttp2 branch October 24, 2019 16:39
artem-kamyshev pushed a commit to artem-kamyshev/conan-center-index that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants