[qt5] only check for python2 at build time #16941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boussaffawalid
changed the title
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
ghost
mentioned this pull request
|
I detected other pull requests that are modifying qt/5.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Apr 8, 2023
Merged
use validate_build
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
ericLemanissier
approved these changes
Apr 9, 2023
Hooks produced the following warnings for commit 4313cbbqt/5.15.8qt/5.15.6qt/5.15.5qt/5.15.7 |
jwillikers
approved these changes
Apr 10, 2023
prince-chrismc
approved these changes
Apr 10, 2023
MartinDelille
pushed a commit
to MartinDelille/conan-center-index
that referenced
this pull request
Apr 12, 2023
* only check for python2 at build time * use validate_build --------- Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qt/5.x
python2is only needed to build qt. Movedpython2verification tobuild_requirementsasvalidatemethod is also executed when using the qt package.In other words, you don't need
python2to be installed if you want to use pre compiled binaries.