Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readd self version check for macOS armv8 compatibility #16357

Closed
wants to merge 1 commit into from
Closed

readd self version check for macOS armv8 compatibility #16357

wants to merge 1 commit into from

Conversation

witte
Copy link

@witte witte commented Mar 3, 2023

Specify library name and version: sentry-native/>=5.0

This fixes #16352 by bringing back this version check.

With conan 1.59.0 this makes the recipe work again on macOS armv8.
With conan 2.0 I still this error at the end (on sentry-crashpad, which is a requirement of sentry-native:
image
which seems to be the same as issue #13187.

Both conan versions were tested with sentry-native versions 0.5.0 and 0.5.4.


@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

🤖 Beep Boop! This pull request is making changes to 'recipes/sentry-//*'.

👋 @MartinDelille you might be interested. 😉

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@ghost
Copy link

ghost commented Mar 3, 2023

I detected other pull requests that are modifying sentry-native/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Contributor

@MartinDelille MartinDelille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed to remove version before 0.4.17 here which would make this PR not necessary: #16049

@witte
Copy link
Author

witte commented Mar 5, 2023

You're right, @MartinDelille. Usually I'd be wary of removing versions that are not that old, but the same changes have already been merged for sentry-crashpad in your PR here and the consistency makes sense.

I'm closing this one and will keep an eye on #16049, thanks!

@witte witte closed this Mar 5, 2023
@MartinDelille
Copy link
Contributor

There is a policy regarding old version: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#removing-old-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] <sentry-native>/<0.5.0>: Invalid ARM architecture
4 participants