-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readd self version check for macOS armv8 compatibility #16357
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/sentry-//*'. 👋 @MartinDelille you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Sorry, the build is only launched for Access Request users. You can request access writing in this issue. Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
I detected other pull requests that are modifying sentry-native/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed to remove version before 0.4.17 here which would make this PR not necessary: #16049
You're right, @MartinDelille. Usually I'd be wary of removing versions that are not that old, but the same changes have already been merged for I'm closing this one and will keep an eye on #16049, thanks! |
There is a policy regarding old version: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#removing-old-versions |
Specify library name and version: sentry-native/>=5.0
This fixes #16352 by bringing back this version check.
With conan 1.59.0 this makes the recipe work again on macOS armv8.
With conan 2.0 I still this error at the end (on
sentry-crashpad
, which is a requirement ofsentry-native
:which seems to be the same as issue #13187.
Both conan versions were tested with
sentry-native
versions0.5.0
and0.5.4
.