-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: add Boost.URL #15011
boost: add Boost.URL #15011
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Did you run the rebuild dependencies script by any chance? |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ae2b9c8boost/1.81.0
boost/1.70.0
boost/1.76.0
boost/1.80.0
boost/1.79.0
boost/1.78.0
boost/1.72.0
boost/1.77.0
boost/1.75.0
boost/1.73.0
boost/1.74.0
boost/1.71.0
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 84fd046boost/1.73.0
boost/1.78.0
boost/1.80.0
boost/1.81.0
boost/1.79.0
boost/1.72.0
boost/1.76.0
boost/1.77.0
boost/1.75.0
boost/1.74.0
boost/1.71.0
boost/1.70.0
|
@prince-chrismc, thank you. I did check and made fixes accordingly. The script added system lib dependency to the URL lib. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There's merge conflicts now |
Also if you could be so kind to sneak in #15105 (comment) id appreciate it ❤️ |
boost: bump b2 to 4.9.3 Update recipes/boost/all/test_package/CMakeLists.txt Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Please do not force push 🙏 GitHub forces us to restart the review which is not fun! |
I'm sorry for that. I reread the guides and will change my habits. |
@jcar87 you need to follow up since you requested changes :) |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit c45f837boost/1.81.0
boost/1.73.0
boost/1.77.0
boost/1.79.0
boost/1.78.0
boost/1.80.0
boost/1.76.0
boost/1.72.0
boost/1.75.0
boost/1.70.0
boost/1.71.0
boost/1.74.0
|
@jcar87 a friendly ping. This PR which is blocked and need your review to unblock 😸 |
Pinged him on slack for better results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @sanblch
This comment has been minimized.
This comment has been minimized.
Thank you 😊 💓 |
Conan v1 pipelineAll green in build 13 (
|
Hooks produced the following warnings for commit c45f837boost/1.76.0
boost/1.74.0
boost/1.81.0
boost/1.79.0
boost/1.78.0
boost/1.80.0
boost/1.77.0
boost/1.75.0
boost/1.73.0
boost/1.70.0
boost/1.71.0
boost/1.72.0
|
libraries = ["fiber", "json", "nowide", "url"] | ||
if Version(self.version) >= "1.76.0": | ||
libraries.append("math") | ||
if Version(self.version) >= "1.79.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the "url"
go under the if Version(self.version) >= "1.81.'":
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would also be correct. But this is a set of c++11 libraries. Libraries that not always c++11 are applied by version. From that point "url" is always c++11. Its appearance in 1.81 is set by dependencies/dependencies-1.81.0.yml
.
boost: bump b2 to 4.9.3 Update recipes/boost/all/test_package/CMakeLists.txt Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Specify library name and version: boost/1.81.0
Closes #14991