[package] openblas/0.3.17: Should use option build_lapack=True by default #7361
Labels
bug
Something isn't working
Comments
samuel-emrys
added a commit
to samuel-emrys/conan-center-index
that referenced
this issue
Sep 21, 2021
* Set default value for build_lapack option to true. This will enable other packages depending on lapack to be packaged to CCI as recipes can only depend on the default options of other packages. Closes conan-io#7361
4 tasks
4 tasks
samuel-emrys
added a commit
to samuel-emrys/conan-center-index
that referenced
this issue
Nov 2, 2023
Version 0.3.21 of openblas introduced the ability to build lapack from C. Make this default to enable CCI recipes to use lapack when depending on openblas. Additionally, fix an inconsistency in version constraint. Review was provided in conan-io#19808 to constrain it to 0.3.24 as this was the latest version available in CCI. However, the constraint on building lapack really applies to anything newer than 0.3.21, so this is the most appropriate model for the logic. Not modelling this accurately precludes the correct behaviour if intermediate versions are added at a later date. Closes conan-io#7361
3 tasks
conan-center-bot
pushed a commit
that referenced
this issue
Jan 5, 2024
* [openblas] Make build_lapack=True default for >= 0.3.21 Version 0.3.21 of openblas introduced the ability to build lapack from C. Make this default to enable CCI recipes to use lapack when depending on openblas. Additionally, fix an inconsistency in version constraint. Review was provided in #19808 to constrain it to 0.3.24 as this was the latest version available in CCI. However, the constraint on building lapack really applies to anything newer than 0.3.21, so this is the most appropriate model for the logic. Not modelling this accurately precludes the correct behaviour if intermediate versions are added at a later date. Closes #7361 * [openblas] Switch option change to config_options from configure Modifying defaults in configure is now prohibited and should be done in config_options instead. * [openblas] Only propagate -lgfortran when compiled with fortran * Add note to explain lapack source when no Fortran compiler is available Co-authored-by: Uilian Ries <uilianries@gmail.com> * [openblas] set TARGET for armv8 builds to facilitate architecture detection * [openblas] Add armv8 compatibility * Patch versions earlier than 0.3.24 to include hotfix of OpenMathLib/OpenBLAS#4142, which fixes detection of the armv8 architecture to ARM64 from ARM. * Refactor patches into a _patch_sources method * Revert 0bd65ec and b42908 * [openblas] Disable armv8 builds for versions lower than 0.3.24. * armv8 is not currently supported by versions lower than 0.3.24 due to a bug in the cpu architecture identification erroneously identifying a 32 bit architecture instead of 64. * [openblas] Re-add erroneously removed version check for when to build lapack This check was erroneously removed when the note about an f2c converted copy of lapack being used was added. The f2c version of lapack is only available for versions greater than or equal to 0.3.21, and versions lower than this should not build lapack by default. --------- Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
openblas currently builds with
build_lapack=False. This comment suggests thatgfortranis now available in Conan Docker Tools (so presumably the CI), and so building LAPACK should now be possible. Previous discussion regarding the decision to setbuild_lapack=Falseas the default can be found here, but essentially it comes down to the fact that it couldn't be built on the CI.This will facilitate the creation of a useful armadillo package, as per #7334. Without LAPACK, armadillo can only operate using a subset of features, and CCI requires that the default configuration for a package uses only default configurations for its dependencies.
The text was updated successfully, but these errors were encountered: