Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
  • Loading branch information
chausner and SpaceIm authored Feb 3, 2023
1 parent 955ef84 commit b6a02cf
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions recipes/flac/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from conan.tools.scm import Version
import os

required_conan_version = ">=1.53.0"
required_conan_version = ">=1.54.0"


class FlacConan(ConanFile):
Expand Down Expand Up @@ -56,8 +56,6 @@ def generate(self):
tc.variables["BUILD_EXAMPLES"] = False
tc.variables["BUILD_DOCS"] = False
tc.variables["BUILD_TESTING"] = False
# Honor BUILD_SHARED_LIBS from conan_toolchain (see https://github.com/conan-io/conan/issues/11840)
tc.cache_variables["CMAKE_POLICY_DEFAULT_CMP0077"] = "NEW"
tc.generate()
cd = CMakeDeps(self)
cd.generate()
Expand Down Expand Up @@ -105,6 +103,7 @@ def package_info(self):
self.output.info("Appending PATH environment variable: {}".format(bin_path))
self.env_info.PATH.append(bin_path)

# TODO: to remove in conan v2
self.cpp_info.filenames["cmake_find_package"] = "flac"
self.cpp_info.filenames["cmake_find_package_multi"] = "flac"
self.cpp_info.names["cmake_find_package"] = "FLAC"
Expand Down

0 comments on commit b6a02cf

Please sign in to comment.