Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix has for 0.18.0 release. #407

Merged
merged 12 commits into from
Apr 4, 2022
Merged

Fix has for 0.18.0 release. #407

merged 12 commits into from
Apr 4, 2022

Conversation

AlphaCluster
Copy link
Contributor

Looks like the readme's hash wasn't updated for the 0.18.0 release.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@czoido czoido added this to the 0.18.1 milestone Apr 4, 2022
@czoido
Copy link
Contributor

czoido commented Apr 4, 2022

Hi @AlphaCluster,
Thanks a lot for the contribution. We'll make a patch for 0.18 and release today the fix.

@czoido czoido changed the base branch from develop to release/0.18 April 4, 2022 10:50
@czoido czoido changed the base branch from release/0.18 to develop April 4, 2022 10:50
@czoido
Copy link
Contributor

czoido commented Apr 4, 2022 •
edited
Loading

This has to be fixed in the release/0.18 branch, not to be target to develop, I'll make the changes to target the other branch
UPDATE: I'll merge this for the 0.18.1 release but removing the check of the hash, that is something that will bite again and should be a choice taken by the developer that uses conan.cmake

@czoido czoido changed the base branch from develop to release/0.18 April 4, 2022 10:55
@czoido czoido merged commit df0f64a into conan-io:release/0.18 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlphaCluster @CLAassistant @czoido