Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VS 17 2022 support #350

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Add VS 17 2022 support #350

merged 1 commit into from
Sep 9, 2021

Conversation

IceflowRE
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

memsharded
memsharded reviewed Jul 30, 2021
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thanks.

The only problem is that Conan itself didn't implement built-in settings for this new version. The ticket is assigned for next release, but until then, this PR will not work yet.

@SSE4
Copy link
Contributor

SSE4 commented Aug 3, 2021 •
edited
Loading

see also conan-io/conan#9362
it should be a first step

@czoido
Copy link
Contributor

czoido commented Aug 9, 2021

Waiting for this PR conan-io/conan#9370 to be merged and release in 1.40.
Adding to 0.17 milestone.

@czoido czoido added this to the 0.17 milestone Aug 9, 2021
@czoido czoido self-assigned this Aug 9, 2021
@maztheman
Copy link

I had to edit conan.conf to use Ninja to be the default generator to get conan to build the packages.

@f1nal3
Copy link

f1nal3 commented Sep 9, 2021

@czoido conan-io/conan#9370 is mergerd and 1.40 is released

@czoido czoido merged commit 7f9fe6d into conan-io:develop Sep 9, 2021
@czoido
Copy link
Contributor

czoido commented Sep 9, 2021

Merged now that Conan 1.40 was realeased

@czoido czoido mentioned this pull request Nov 12, 2021
Closed
@Zvicii Zvicii mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

@SSE4 SSE4 SSE4 approved these changes

Assignees

@czoido czoido

Labels
PR: Under review
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
7 participants
@IceflowRE @CLAassistant @SSE4 @czoido @maztheman @f1nal3 @memsharded