Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update digest archives #714

Merged
merged 2 commits into from
May 14, 2024
Merged

update digest archives #714

merged 2 commits into from
May 14, 2024

Conversation

sgfost
Copy link
Contributor

@sgfost sgfost commented Apr 29, 2024

We still need a link to the digest page, I would say just stick it right here for now:
Screenshot from 2024-04-29 14-59-39
does that seem alright, @alee?

still need a link to digest page
@sgfost sgfost added the content label Apr 29, 2024
@alee
Copy link
Member

alee commented May 2, 2024

sounds good! would be nice to revamp how those secondary tab menus are set up; it's kind of a pain at the moment and involves a fair bit of duplication. I think how we were setting these up was as a management command since each individual page in the tab needs to have that secondary tab nav set on it

@sgfost
Copy link
Contributor Author

sgfost commented May 2, 2024

Yeah, I'd like to think through a bit of a navigation cleanup somewhat soon including comses/planning#114. I don't think the digest page needs to live in /about/ long-term so just a direct link in those tabs should suffice? I can put a script in here for doing so to version it

Copy link
Member

@alee alee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only residual thing that's a little weird is that when you click on the digest page itself you lose the nav that got you there but I don't think there's an easy way to set that up since it's a DigestView, not a legit wagtail Page

@alee alee merged commit ceaaf9a into comses:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants