Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAE-494: Fix payment batch submission after CiviCRM 5.35 upgrade #230

Merged

Commits on Mar 12, 2021

  1. MAE-494: Fix payment batch submission after CiviCRM 5.35 upgrade

    Manual direct debit is using the core method "transitionComponentWithReturnMessage" that is in the Contribution BAO class, though this method is now removed in core (see civicrm/civicrm-core#18961 for more info), and thus it result in failure when submitting the payment batch.
    
    Here I replaced the calls for this method with "transitionComponents",
    given that the former is basicly calling it but just return some extra
    feedback messages, and that these returned feedback messages are not
    even used or showed back to user in this extension, so it is safe to
    just call "transitionComponents" instead.
    omarabuhussein committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    cd67de8 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. MAE-494: Fix PHP warnings

    When using the API v3 `getvalue` action on any entity, it will return
    the return value directly, but some places in direct debit importer
    assumed that it would return the value indexed by the `result` key.
    
    Here I am changing that so results from this API action are used directly.
    omarabuhussein committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    44d902c View commit details
    Browse the repository at this point in the history