PCHR-3376: Update T&A Administer Menu Items #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunbola
suggested changes
Mar 13, 2018
| $params = ['return' => 'id', 'name' => 'tasksassignments_administer']; | ||
| $parentId = (int) civicrm_api3('Navigation', 'getvalue', $params); | ||
| $params = ['return' => 'id', 'name' => 'ta_settings']; | ||
| $taSettingsId = (int) civicrm_api3('Navigation', 'getvalue', $params); |
There was a problem hiding this comment.
Why don't we just call the Navigation API once to get the ids of the menu's rather than twice?
| } | ||
|
|
||
| // Update parent weight | ||
| civicrm_api3('Navigation', 'create', ['id' => $parentId, 'weight' => -97]); |
There was a problem hiding this comment.
We can actually update permission and weight of the parentID in one call and the permission of taSettingsId in another call, which means we will call the API two times rather than three.
We can have a function do this that will optionally update the permission or not if present
tunbola
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We are changing what menu items can be accessed. T&A provides some items for the "Configure" submenu, and these will be altered.
Before
After
administer CiviCase.