-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USDT market on Arbitrum #830
Open
vincetiu8
wants to merge
71
commits into
compound-finance:hans/goerli-usdt-deploy
Choose a base branch
from
vincetiu8:franklindao/arbitrum-usdt
base: hans/goerli-usdt-deploy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add USDT market on Arbitrum #830
vincetiu8
wants to merge
71
commits into
compound-finance:hans/goerli-usdt-deploy
from
vincetiu8:franklindao/arbitrum-usdt
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is the title of this PR "Add USDT market on Arbitrum" and the forum thread is titled "Launch USDT Market on Compound v3 Ethereum"? The discrepancy is the network to deploy the instance to. Which is it? Mainnet or Arbitrum? Is this a mistake or has the intent of the proposal creator changed? |
This PR adds support for Sepolia and deploys a new USDC market there. More work will need to be done to migrate cross-chain governance from L2s to point to Sepolia instead of Goerli, but this should help to unblock developers that need access to a Comet on Sepolia.
Deploys cWETHv3 to Sepolia and initializes it with a proposal.
d19b0e4
to
61c803f
Compare
Create deployment and market initialization proposals on Scroll mainnet and Scroll Alpha testnet (bridged to Goerli) for USDC market by @isabellewei from the Scroll team --------- Co-authored-by: isabellewei <isabelle.wei@yahoo.ca> Co-authored-by: Isabelle Wei <isabellewei@Isabelles-MacBook-Pro.local> Co-authored-by: isabelle <isabelle@scroll.io>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
…h new Comet logics that will compare Comet's raw balance diff to credit user in accounting. Comet's always got 0 token, so comet always credit 0, thus it won't hit SupplyCapExceeded() error no more
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
…acts went over 24.576kb
…ready in-use in other contracts
61c803f
to
571a370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #827.
Copies variables from USDC Arbitrum deployment.
Assets: