Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: support trilogy adapter #607

Merged
merged 21 commits into from
Nov 4, 2023
Merged

Feature: support trilogy adapter #607

merged 21 commits into from
Nov 4, 2023

Commits on Sep 12, 2023

  1. add trilogy to Gemfile

    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c5edd75 View commit details
    Browse the repository at this point in the history

  2. create trilogy rake task and add it to Rakefile 

    and console script
    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    802587b View commit details
    Browse the repository at this point in the history

  3. bundle current github workflows without trilogy

    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8c55d81 View commit details
    Browse the repository at this point in the history

  4. add trilogy to databases.ci.yml

    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a331a2a View commit details
    Browse the repository at this point in the history

  5. ensure trilogy AR connection files are added 

    and specify #cpk_mysql_subquery if TrilogyAdapter is defined
    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2109996 View commit details
    Browse the repository at this point in the history

  6. add private method to control #value returned 

    One thing we need to ensure overall is that and ActiveRecord::Result is returned as the guts of the gem is looking to work with that object. A Trilogy::Result was being returned as `value`and that doesn't respond to #empty?
    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2b6df26 View commit details
    Browse the repository at this point in the history

  7. connect to the db if trilogy adapter used 

    We need to load some more files as AR isn't aware of trilogy
    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    bcf5e48 View commit details
    Browse the repository at this point in the history

  8. create github trilogy workflow

    @zmariscal
    zmariscal committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5d8bbf5 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. use the trilogy adapter in the db.ci yml file

    @zmariscal
    zmariscal committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    dc079a2 View commit details
    Browse the repository at this point in the history

  2. remove require statements as they aren't needed

    @zmariscal
    zmariscal committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f46d5ac View commit details
    Browse the repository at this point in the history

  3. Remove constant and follow pattern of if block 

    there's a pattern already in place as the constant may not always be defined
    @zmariscal
    zmariscal committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3fc6466 View commit details
    Browse the repository at this point in the history

  4. revert trilogy additions in test file

    @zmariscal
    zmariscal committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    32ef97f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. when adding trilogy to various places 

    I accidentally added it to its own github action
and we for sure need trilogy here
    @zmariscal
    zmariscal committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    69aced2 View commit details
    Browse the repository at this point in the history

  2. if value doesn't respond to #empty? we don't want to continue

    @zmariscal
    zmariscal committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c95dc75 View commit details
    Browse the repository at this point in the history

  3. when running tests we need to ensure AR is aware of Trilogy 

    so load it and make the DB connection
    @zmariscal
    zmariscal committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e5f311e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. add github action steps to resolve database.yml or DATABASE_URL 

    trilogy-libraries/activerecord-trilogy-adapter#64
    @zmariscal
    zmariscal committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3de57ac View commit details
    Browse the repository at this point in the history

  2. update github envs appropriately

    @zmariscal
    zmariscal committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    334b5a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. target host when executing github action

    @zmariscal
    zmariscal committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    1bc20ba View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. update workflow and order the args for the mysql command differently

    @zmariscal
    zmariscal committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    9311e0d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Merge branch 'master' into feature--support-trilogy-adapter

    @zmariscal
    zmariscal committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    663f12a View commit details
    Browse the repository at this point in the history

  2. remove trilogy github action for now

    @zmariscal
    zmariscal committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f79e913 View commit details
    Browse the repository at this point in the history