Fixes #67: Adds ability to disable all or certain installers #376
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,6 +103,30 @@ class Installer extends LibraryInstaller | |
| 'prestashop' => 'PrestashopInstaller' | ||
| ); | ||
|
|
||
| /** | ||
| * Installer constructor. | ||
| * | ||
| * Disables installers specified in main composer extra installer-disable | ||
| * list | ||
| * | ||
| * @param IOInterface $io | ||
| * @param \Composer\Composer $composer | ||
| * @param string $type | ||
| * @param \Composer\Util\Filesystem|null $filesystem | ||
| * @param \Composer\Installer\BinaryInstaller|null $binaryInstaller | ||
| */ | ||
| public function __construct( | ||
| \Composer\IO\IOInterface $io, | ||
| \Composer\Composer $composer, | ||
| $type = 'library', | ||
| \Composer\Util\Filesystem $filesystem = null, | ||
| \Composer\Installer\BinaryInstaller $binaryInstaller = null | ||
| ) { | ||
| parent::__construct($io, $composer, $type, $filesystem, | ||
| $binaryInstaller); | ||
| $this->removeDisabledInstallers(); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
|
|
@@ -198,4 +222,44 @@ private function getIO() | |
| { | ||
| return $this->io; | ||
| } | ||
|
|
||
| /** | ||
| * Look for installers set to be disabled in composer's extra config and | ||
| * remove them from the list of supported installers. | ||
| * Uses true, "all", and "*" as global values to disable all installers. | ||
| * | ||
| * @return void | ||
| */ | ||
| protected function removeDisabledInstallers() | ||
| { | ||
| $extra = $this->composer->getPackage()->getExtra(); | ||
|
|
||
| if (!isset($extra['installer-disable'])) { | ||
|
There was a problem hiding this comment. It may be worth to consider options There was a problem hiding this comment. Given that Is your thought that this would be a global, "all installers are enabled"? Regarding an options array, what did you have in mind? I'm not at all opposed to having available options, but I'm not sure what options to include or what they would do? Or are you suggesting to have it available for future ideas? There was a problem hiding this comment. @niksamokhvalov |
||
| // No installers are disabled | ||
| return; | ||
| } | ||
|
|
||
| // Get installers to disable | ||
| $disable = $extra['installer-disable']; | ||
|
|
||
| // Ensure $disabled is an array | ||
| if (!is_array($disable)) { | ||
| $disable = array($disable); | ||
| } | ||
|
|
||
| // Check which installers should be disabled | ||
| $all = array(true, "all", "*"); | ||
| $intersect = array_intersect($all, $disable); | ||
| if (!empty($intersect)) { | ||
| // Disable all installers | ||
| $this->supportedTypes = array(); | ||
| } else { | ||
| // Disable specified installers | ||
| foreach ($disable as $key => $installer) { | ||
| if (is_string($installer) && key_exists($installer, $this->supportedTypes)) { | ||
| unset($this->supportedTypes[$installer]); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are already imported, can you just use their short classname? Same for docblocks please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done