This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
Feature/elasticsearch routing properly #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 84.07% 84.12% +0.04%
==========================================
Files 61 61
Lines 4176 4182 +6
==========================================
+ Hits 3511 3518 +7
Misses 494 494
+ Partials 171 170 -1
Continue to review full report at Codecov.
|
|
this looks good! it hit a golint issue that cropped up but I've updated master to fix the test. can you give it a rebase? |
added test scenarios where parent-child is updated added test scenarios where parent-child is deleted added test scenarios where parent-child _routing is detected and mapped properly
|
@jipperinbham tests are passing! Please let me know when you can send me a sample dockerfile or when you can get a quay build going. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: