(Phase 1) Multi namespace support #101
Conversation
|
@alindeman if you can, could you take a look at the RethinkDB changes? |
| @@ -65,7 +66,7 @@ func NewPipe(pipe *Pipe, path string) *Pipe { | |||
| // Listen starts a listening loop that pulls messages from the In chan, applies fn(msg), a `func(message.Msg) error`, and emits them on the Out channel. | |||
| // Errors will be emited to the Pipe's Err chan, and will terminate the loop. | |||
| // The listening loop can be interupted by calls to Stop(). | |||
| func (m *Pipe) Listen(fn func(*message.Msg) (*message.Msg, error)) error { | |||
| func (m *Pipe) Listen(nsFilter *regexp.Regexp, fn func(*message.Msg) (*message.Msg, error)) error { | |||
There was a problem hiding this comment.
i probably would flip the args here..
p.Listen(fn, rx)
(sorry)
|
LGTM |
|
looks good, we can save that refactor for later though if you want to merge now |
|
I reversed the params to |
(Phase 1) Multi namespace support
|
I am trying to use this multi namespace but i got some error: application.js pipeline = Source({name:"localmongo", namespace:"admin./(eshops|masterProducts|masterCategories)/"})
pipeline.save({name:"es", namespace:"admin.eshops"})
pipeline.save({name:"es", namespace:"admin.masterProducts"})
pipeline.save({name:"es", namespace:"admin.masterCategories"})the error: |
|
@jipperinbham I can confirm that your fix works, thank you very much! |
Addresses #78 based on implementation discussed in #23
The following allows for processing more than 1 collection/table at a time. The current Source adaptors, MongoDB and RethinkDB, have been updated to properly handle this change but the RethinkDB adaptor does NOT automagically pick up new tables added to the database.
An example of how one could pick and choose what namespaces they wanted to sync:
You can also create transformers in the pipeline which have access to the namespace if you need to alert it inflight.