-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Klevu Components integration #25
Conversation
|
Name | Link |
---|---|
🔨 Latest commit | 360980c |
@rallu is attempting to deploy a commit to the Composable Development Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The changes applied by following the installation steps must be able to successfully deploy to Vercel and Netlify, please provide a link to a deploy running on Vercel and Netlify
- pnpm-lock.yaml file was not updated and prevented build on Vercel, see PR comment
- Klevu UI components must be built with Chakra UI
- The Klevu UI components should be built with Chakra UI to fit into the Composable UI component ecosystem, and can be most likely be based on, or use, the components that power the default Product Listing Page
- Concern: separate CSS files are imported in _app.tsx to style the Klevu components.
- This diverges from the Chakra UI theme, and takes the styling and building of these components out of Chakra UI and into an isolated pattern for Klevu
- Can lead to several issues: specificity issues, ssr issues, difficulty in theming
- command # 6 in Klevu README needs to be escaped
- cp ../packages/klevu/copythese/\[slug\].tsx src/pages/category/\[slug\].tsx
- command # 8 in readme should provide sample code of the QuickSearch component placed in header.tsx, with a sample screenshot of the code and expected UI output
- The Klevu README should contain screenshots of the outcome after installation of all Kelvu code + components
- Please explain how to create a new Klevu account and sandbox
- How to configure a new Klevu sandbox
- How to retrieve the API keys used for KLEVU_API_KEY and KLEVU_REST_KEY
- How to populate this new sandbox to power the Product Listing Page and QuickSearch
- klevu.tsx has hard coded variables: apiKey, url, and assetsPath
- These should be changed to environment variables
- README does not explain whether "Data Indexing in Klevu” is an additional optional step or if it is required for the QuickSearch component.
- Will QuickSearch function only after this step has been completed?
- Product grid is not contained within max page width, see screenshot
@rallu please also add a page to in the Docusaurus app in Please add an introduction, screenshots, etc - anything you would want a developer to understand about the integration to Klevu, and how to get started. Referencing the |
360980c
to
ff5a492
Compare
ff5a492
to
1456a3e
Compare
New version of Klevu installation instructions has been added. We have done following changes:
|
@rallu I'll be looking at reviewing + merging this PR this week. |
@dannytlake Hello Danny, my name is Nikhil and I work in the Klevu components team. I wanted to check if anything is still pending in this PR and if you need anything else from our side to get this merged. Let me know. Thanks. |
Hello @nikhil-narayana-klevu, nice to meet you.
Please let me when the two items above are completed, and then I will run through the install instructions again to verify I can successfuly install Klevu UI and run the components on the storefront. I also suggest adding screenshots to the documentation ( Thank you! |
Hi @nikhil-narayana-klevu, thank you for resetting my account. I'm not able to successfully run the setup process of importing products via command Please see the below logs as I run the command. I am receiving error
Am I expected to modify this script? I see this message in the Klevu integration doc:
Should I be able to successfully upload the default product dataset without any code modifications? |
Hi @dannytlake |
Thank you @nikhil-narayana-klevu, One small issue I see is the Global Search component, there is an "undefined" row in the "Last searches" section. Even if I perform a couple of searches, the "undefined" row still exists. Can you please investigate? |
@dannytlake I am unable to replicate on my end. can you try once in an Incognito window and check? |
@nikhil-narayana-klevu clearing the site data for localhost:3000 solved the issue. Everything looks great now thank you for working on these last few items. |
composable-ui/package.json
Outdated
@@ -27,6 +27,9 @@ | |||
"@emotion/react": "^11.9.3", | |||
"@emotion/styled": "^11.9.3", | |||
"@hookform/resolvers": "^2.9.7", | |||
"@klevu/core": "^5.0.0", | |||
"@klevu/ui": "^2.0.0", | |||
"@klevu/ui-react": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil-narayana-klevu please remove these dependencies, as they should not be a part of the baseline composable-ui package.json. The developer will install these when following the Klevu install documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed these packages. Please check now.
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil-narayana-klevu please regenerate this lock file. There is an issue in this lock file, it downgrades many dependencies compared to the lock file in main
. Please start with a fresh working copy from here and re-run pnpm i
to update the lock file in this branch as needed. This current lock file is the breaking build of the next.js application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is updated, please check now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nikhil-narayana-klevu
Overview
This pull request introduces a practical guide for integrating Klevu's advanced AI-driven search functionalities into the Composable-UI framework. Klevu, renowned for its e-commerce search capabilities, offers features like autocomplete, natural language processing, and machine learning insights, all aimed at elevating the user experience on e-commerce platforms.
Challenge
A key challenge in this integration is the circular dependency between @composable/klevu and @composable/ui. Housing these components in separate packages would create interdependencies that are impractical for efficient development and deployment.
Solution
To circumvent this issue, we propose a streamlined approach. This integration comprises three essential files rather than creating separate packages. These files are designed to be seamlessly integrated into the main project's structure.
Implementation Guide
Detailed instructions for the integration process are provided in the attached README. This guide outlines the necessary steps to embed Klevu's search components into your Composable-UI project, ensuring a smooth and effective integration.