-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make generated functions safe for extension #426
Conversation
Performance Ratio:
|
Not true: I'm now seeing them locally. |
@willtebbutt, can we add a new benchmark test case based on Lines 1057 to 1059 in 8e7ee73
|
…m/compintell/Mooncake.jl into wct/more-safe-generated-functions
As discussed in #422 , my use of generated functions throughout Mooncake is somewhat unsafe, in the sense that they often use functions which I expect will have methods added to them as part of codegen (see #422 (comment) for further discussion). I discovered that this is a problem while trying to write the extensions necessary to handle GPUArrays properly. Since this is quite a pervasive issue, I need to resolve it asap in order to finish up our initial GPU support work.
It is helpful to have this working PR open in order to regularly run CI to check that nothing has broken as I work through the various fixes which are needed.
todo: