Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Error Message #425

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Improved Error Message #425

merged 5 commits into from
Dec 16, 2024

Conversation

willtebbutt
Copy link
Member

Extends #424 slightly with an improved error message. Hopefully it'll mean that if someone encounters a related error in future, it will be really very straightforward to fix the problem quickly.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/rrules/blas.jl 99.21% <100.00%> (+<0.01%) ⬆️

Copy link
Contributor

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │     72.2 │     1.0 │         5.5 │    8.21 │
│                  _sum_1000 │     6.59 │  1190.0 │        38.2 │    1.09 │
│               sum_sin_1000 │      2.3 │    1.68 │        10.8 │    1.97 │
│              _sum_sin_1000 │     2.61 │   271.0 │        13.2 │    2.41 │
│                   kron_sum │     75.2 │    4.76 │       252.0 │  1140.0 │
│              kron_view_sum │     55.7 │    8.92 │       206.0 │    91.3 │
│      naive_map_sin_cos_exp │      2.5 │ missing │        7.31 │    2.35 │
│            map_sin_cos_exp │     2.77 │    1.45 │         6.1 │    2.92 │
│      broadcast_sin_cos_exp │     2.62 │    3.73 │        1.46 │    2.27 │
│                 simple_mlp │     4.91 │    3.16 │        6.68 │    3.39 │
│                     gp_lml │     13.1 │    6.16 │     missing │    8.19 │
│ turing_broadcast_benchmark │     3.16 │ missing │        24.3 │ missing │
│         large_single_block │     4.03 │  4170.0 │        30.1 │    2.18 │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit edf9607 into main Dec 16, 2024
72 checks passed
@willtebbutt willtebbutt deleted the wct/improved-error-message branch December 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant