Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve safe mode messaging #189

Closed
wants to merge 2 commits into from
Closed

Improve safe mode messaging #189

wants to merge 2 commits into from

Conversation

willtebbutt
Copy link
Member

Addresses #168 . As discussed in SciML/ADTypes.jl#68, safe_mode is part of the public interface of ADTypes as it is a documented field of the AutoTapir type. This means that we cannot change it without making a breaking change to ADTypes. Since we can't do this, it seems preferable to simply clarify the nature of safe mode / the safety_on kwarg, then to rename it and have multiple names floating around.

The purpose of this PR, therefore, is to improve the documentation around safe_mode / safety_on, to ensure that users are aware of what it does.

@willtebbutt
Copy link
Member Author

Closed in favour of improving #175

@willtebbutt willtebbutt closed this Jul 1, 2024
@willtebbutt willtebbutt deleted the wct/rename_safe_mode branch July 1, 2024 11:21
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Performance Ratio:
Warning: results are very approximate!

┌────────────────────────────┬────────┬─────────┬─────────────┬─────────┐
│                      Label │  Tapir │  Zygote │ ReverseDiff │  Enzyme │
│                     String │ String │  String │      String │  String │
├────────────────────────────┼────────┼─────────┼─────────────┼─────────┤
│                        sum │   49.1 │   0.458 │        3.19 │   0.681 │
│                       _sum │   6.79 │   488.0 │        27.1 │   0.121 │
│                   kron_sum │   87.8 │    3.55 │       216.0 │    25.8 │
│              kron_view_sum │   97.3 │    11.6 │       256.0 │    8.49 │
│      naive_map_sin_cos_exp │   4.12 │ missing │        8.86 │    2.78 │
│            map_sin_cos_exp │   4.76 │    1.77 │        7.48 │    3.38 │
│      broadcast_sin_cos_exp │   4.39 │     2.6 │        1.67 │    2.84 │
│                 simple_mlp │   8.89 │    3.09 │        11.4 │    3.16 │
│                     gp_lml │   15.8 │    4.92 │     missing │ missing │
│ turing_broadcast_benchmark │   8.52 │ missing │        25.7 │ missing │
└────────────────────────────┴────────┴─────────┴─────────────┴─────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant