Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try/catch wrappers for SoupX and Scrublet #719

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

mingl1997
Copy link
Collaborator

Fixes:
-Try/catch wrapper for SoupX in the event that no marker genes are found
-Try/catch wrapper for Scrublet in the event of an unexpected crash
To do:
-Isolate combineSCE bug (inner join?) and fix

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (8f3e43f) 52.77% compared to head (8555c7a) 52.75%.

❗ Current head 8555c7a differs from pull request most recent head 4b867a3. Consider uploading reports for the commit 4b867a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #719      +/-   ##
==========================================
- Coverage   52.77%   52.75%   -0.02%     
==========================================
  Files          79       79              
  Lines       12696    12700       +4     
==========================================
  Hits         6700     6700              
- Misses       5996     6000       +4     
Files Coverage Δ
R/runSoupX.R 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshua-d-campbell joshua-d-campbell merged commit ac07278 into compbiomed:devel Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants