Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid date appears for Acknowledged On when add auto-ECLA contributor #4264

Closed
thakurveerendras opened this issue Mar 1, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@thakurveerendras
Copy link
Contributor

Summary

The invalid date appears for Acknowledged On when add the auto-ECLA contributor

Background

  1. login company portal
  2. Go to the easycla page
  3. Enable Auto-ecla
  4. Now add the user under the approval list

Expected behavior

Acknowledged On should be proper

Screenshots

image

@thakurveerendras thakurveerendras added the bug Something isn't working label Mar 1, 2024
@jberkus
Copy link

jberkus commented Aug 21, 2024

I'm also experiencing this issue:

Pasted image 8

Note that older contributors (earlier than 2024) do not have this problem, so it's something in the last year of changes.

@nickmango
Copy link
Contributor

Noted @jberkus shall look into this

nickmango added a commit to nickmango/easycla that referenced this issue Oct 13, 2024
- Resolved missing datestamp values for new ecla records

Signed-off-by: Harold Wanyama <hwanyama@contractor.linuxfoundation.org>
nickmango added a commit that referenced this issue Oct 13, 2024
@nickmango
Copy link
Contributor

@thakurveerendras kindly verify this. For new users the dates will be shown. For the older users will have to run a migration to update the timestamp for the affected ecla records

@thakurveerendras
Copy link
Contributor Author

Thanks @nickmango
Tested the below scenario & found that it is working fine, So updating this ticket status

Scenario: 1 - Add/remove the user from the approval list when AUTO_ECLA is ON
Scenario: 2 - Add/remove the user from the approval list when AUTO_ECLA is OFF
Scenario: 3 -User Acknowledged using contributor flow (covered Both ICLA required & ICLA not Required use case)

@thakurveerendras
Copy link
Contributor Author

Scenario 4: Tested use case mentioned in issue ##4435 & found that invalid date case is not reproducible

@jberkus
Copy link

jberkus commented Oct 17, 2024

If it's fixed, can you keep this open until you fix the timestamps from the buggy period?

@nickmango
Copy link
Contributor

sure thing . Ive moved this to progress as I complete the migration script to update the invalid date fields

@mlehotskylf
Copy link
Contributor

mlehotskylf commented Oct 29, 2024

This is already fixed in DEV and tested, moving to QA Review Completed.

nickmango added a commit to nickmango/easycla that referenced this issue Nov 4, 2024
- Resolved missing datestamp values for new ecla records

Signed-off-by: Harold Wanyama <hwanyama@contractor.linuxfoundation.org>
@mlehotskylf
Copy link
Contributor

This is done for new entries and @nickmango is working on updating existing records in ticket the #4468

@mlehotskylf
Copy link
Contributor

Closing as DONE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants