EascyCLA doesn't check for co-authors

[molssongroup]

Ticket: SUPPORT-17284

The reporting user wants to know if EasyCLA checks for co-authors. They state, "...I make tests (first, second, third) and EasyCLA ignore Co-authors, but check authors, no matter is the PR diff include their work or not."

Does EasyCLA not check for co-authors?

[dealako]

EasyCLA checks each and every commit author associated with a given comment. EasyCLA also checks all the commits associated with the pull request/merge request.

Can you provide a specific example of this not working?

[mlehotskylf]

@dealako examples: (kubernetes/website#40440, kubernetes/website#40439, kubernetes/website#40282)

[WillsonHG]

We need to test this to see if 1) are the logs reporting the co-author information and are we checking for this authorization and then 2) if so, this may be a display issue. @nickmango @thakurveerendras

[thakurveerendras]

Hello @nickmango , @umeshlumbhani247
Kindly refer steps to replicate this issue

1. Clone repo on local system

• Add git branch : git checkout -b coauth14

3. Made some changes on file

• git add .
• git commit -m "Add commit by auth" --author "thakurveerendras1 veerendrat+1@proximabiz.com" --signoff
• git push origin coauth14

7. Made some changes on file again

• git add .
• git commit -m "test Co-auth" -m "Co-authored-by: vrthakur thakur.viren17@gmail.com"
• git push origin coauth14

11. Login GitHub via user thakurveerendras1
12. create PR https://github.com/sun-test-org/repo1/pull/31/commits
    

[wanyaland]

@molssongroup currently EasyCLA does not receive co-author information from github api and we are working on a workaround for this issue. Thanks

[thakurveerendras]

user is missing the User's ID appears for co-authors, kindly refer below screenshot
PR : sun-test-org/repo1#33

[thakurveerendras]

Reported issue is not reproducible , refer PR details

PR: sun-test-org/repo1#34

[thakurveerendras]

commit added by main author details missing , refer steps to replicate it

1. Clone repo on local system via user thakurveerendras
2. Add git branch : git checkout -b coauth14
3. Made some changes on file
4. git add .
5. git commit -m "Add commit by auth" --author "thakurveerendras1 veerendrat+1@proximabiz.com" --signoff
6. git push origin coauth14
7. Login GitHub via user thakurveerendras1
8. create PR : Coauth18 sun-test-org/repo1#35

[wanyaland]

@thakurveerendras for testing use this format to add co-authors
$ git commit -m "Refactor usability tests.

Co-authored-by: NAME NAME@EXAMPLE.COM

[thakurveerendras]

Now unknow "@web-flow " added on easycla boat , @nickmango kindly check

• PR : Coauth20 sun-test-org/repo1#37

[mlehotskylf]

@thakurveerendras to re-test.

[thakurveerendras]

Tested issue on dev site & found that it is fixed as expected

• Now coauthor & author easycla check appears at cla boat , So making issue status QA-Done at Dev site
• Refer PR : Coauth34 sun-test-org/repo1#46

[thakurveerendras]

Tested issue on production & found that it is deployed as expected, So making issue status QA-Done

• PR link : Coauth01 CLATestOrg/VulDetect1#21
  Kindly refer screenshot for more details

[mlehotskylf]

We're reopening this ticket because we temporarily disabled this feature due to a potential performance issue. We're actively working to restore it as soon as possible.

[nickmango]

@thakurveerendras @umeshlumbhani247 re-activated this. Kindly review

[thakurveerendras]

Tested on the dev site & found that coauthor detail is properly appears on PR

• Refer to the screenshot

[umeshlumbhani247]

Hi, @mlehotskylf
I have finish testing on local and Dev stage, On Dev stage, After including co-authors, I got variation of 3% to 5% in Dev while comparing with previous benchmarks.
But in prod, depending on infrastructure, count may vary and variation can be less then Dev.
CC: @thakurveerendras @dealako

[thakurveerendras]

Tested on prod & found that coauthor details are properly appears on cla-commit

[jarias-lfx]

@umeshlumbhani247 can you check kubernetes/website#45174 this one has co-authors and after running /easycla there are no updates. We don't have records for https://github.com/yermulnik and https://github.com/sh1895.
cc @mlehotskylf

[umeshlumbhani247]

@jarias-lfx
It seems a strange , The PR doesn't have a single easycla check comment earlier too.
Let me dig deep into this

[mlehotskylf]

@nickmango identified the root cause and will deploy the fix to DEV later this week for QA testing.

[mlehotskylf]

@thakurveerendras can you please create 6 PRs to cover our use cases for co-author and send me the link:

1. PR 1: [FAIL] PR with 1 co-author. Author and co-author should not sign EasyCLA.
2. PR 2: [FAIL] PR with 1 co-author. Author should have signed EasyCLA, co-author should not have public email (missing ID case).
3. PR 3: [FAIL] PR with 1 co-author. Author should have signed CLA, co-author should not.
4. PR 4: [FAIL] PR with 1 co-author. Co-author should have signed CLA, author should not.
5. PR 5: [PASS] PR with 1 co-author. Both author and co-author should have signed CLA.
6. PR 6: [FAIL] PR with 2 co-author. Author and first co-author should have signed CLA, 2nd co-author should not.
7. PR 7: [FAIL] PR with 2 co-author. First and second co-author should have signed CLA, author should not.
8. PR 8: [PASS] PR with 2 co-author. Author and and both co-authors should have signed CLA.

[nickmango]

This is another usecase kubernetes/website#45174

[thakurveerendras]

Hello @mlehotskylf , @nickmango
Kindly refer requested PR with there easycla & testing results

Case	Summary	Easycla status	status	PR link
1	PR with 1 co-author. Author and co-author should not sign EasyCLA.	Not covered	Passed	sun-test-org/repo1#172
2	PR with 1 co-author. Author should have signed EasyCLA, co-author should not have public email (missing ID case)	Not covered - missing ID	Passed	sun-test-org/repo1#169
3	PR with 1 co-author. Author should have signed CLA, co-author should not.}	Not covered	Passed	sun-test-org/repo1#171
4	PR with 1 co-author. Co-author should have signed CLA, author should not.	Not covered	Passed	sun-test-org/repo1#173
5	PR with 1 co-author. Both author and co-author should have signed CLA.	Covered	Passed	sun-test-org/repo1#176
6	PR with 2 co-author. Author and first co-author should have signed CLA, 2nd co-author should not.	Not covered	Passed	sun-test-org/repo1#174
7	PR with 2 co-author. First and second co-author should have signed CLA, author should not.	Not covered	Passed	sun-test-org/repo1#175
8	PR with 2 co-author. Author and and both co-authors should have signed CLA.	Covered	Passed	sun-test-org/repo1#177

[mlehotskylf]

We are waiting for EasyCLA documentation to be updated before pushing this to PROD.

[mlehotskylf]

https://docs.linuxfoundation.org/lfx/easycla/v2-current/easycla-and-co-author-compliance-guide

[mlehotskylf]

We have decided not to support the co-author feature at this time, so closing this ticket.