Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hoarder build failure by installing Chromium stable #723

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

vhsdream
Copy link
Contributor

@vhsdream vhsdream commented Dec 7, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Chromium recently had an update which causes the Hoarder build to fail. This PR fixes the issue by specifying that Debian install Chromium and Chromium-common from the stable repo rather than the Security repo. After the container is built and when a user decides to update the system, Debian will handle this correctly by holding the packages back until it's dependencies are updated.

Fixes #719

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Anyone who installed Hoarder via the script prior to the Chromium package update may need to manually intervene to fix conflicts prior to updating the system (running the update script is fine). Recommend that they run:

apt autoremove chromium
apt update && apt install chromium/stable chromium-common/stable

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@vhsdream vhsdream requested a review from a team as a code owner December 7, 2024 02:40
@github-actions github-actions bot added the update script A change that updates a script label Dec 7, 2024
@MickLesk MickLesk requested a review from havardthom December 7, 2024 09:34
@havardthom havardthom merged commit be4e650 into community-scripts:main Dec 7, 2024
1 check passed
@vhsdream vhsdream deleted the hoarder-fix branch December 7, 2024 12:43
dsiebel pushed a commit to dsiebel/ProxmoxVE that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hoarder Script Fails during package installation
3 participants