Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Update create-lxc.sh / Improve error messages #1 #2049

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

michelroegl-brunner
Copy link
Member

✍️ Description

This PR updates create-lxc.sh and reworks the error messages.
Befor it was just error "some string", but this never kills the the spinner and leaves the shell in a unwanted state.

I´ve updated the error messages to use msg_error "some string" to better handel this case.

In preperation for better error messages each error gets its own designated error code, to send the correct message to the api.

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • [] Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Before change:
image
After change:
image

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner February 5, 2025 12:52
@github-actions github-actions bot added update script A change that updates a script maintenance Code maintenance or general upkeep of the project labels Feb 5, 2025
@michelroegl-brunner michelroegl-brunner changed the title [core] Update create-lxc.sh [API] Update create-lxc.sh / Improve error messages #1 Feb 5, 2025
tremor021
tremor021 previously approved these changes Feb 5, 2025
@MickLesk MickLesk requested a review from tremor021 February 5, 2025 15:22
@michelroegl-brunner michelroegl-brunner merged commit 5451e61 into main Feb 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance or general upkeep of the project update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants