CLDC-3852 Add some BU documentation #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2920 |
Dinssa
reviewed
Jan 30, 2025
docs/bulk_upload.md
Outdated
Comment on lines
22
to
25
|
|
||
| - Successful upload | ||
| - Partial upload: upload has errors but partial logs can be created, need a user approval | ||
| - Errors in bulk upload: errors on important fields, or in the template. Logs can't be created and email with errors is sent to the user |
There was a problem hiding this comment.
This might imply that an email with errors is only sent when there are important errors, don't we also send emails for partial uploads. In both cases we do direct the user to an error report, maybe worth mentioning that? Also, the email doesn't actually include the errors just a message that there are some.
There was a problem hiding this comment.
Yeah, that's a good point. I updated it a bit now.
I think in some cases we do send the errors directly in the email (if there's an issue with the template), I've updated it to include both
Dinssa
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.