CLDC-3850: Clear postcode_known when clearing postcode_full #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2910 |
RachaelBooth
force-pushed
the
BuCreationBlockedBugfix
branch
from
28ed3dd to
8c07199
Compare
RachaelBooth
commented
Jan 22, 2025
| @@ -258,6 +263,8 @@ def blank_compound_invalid_non_setup_fields! | |||
| self.address_line2 = nil | |||
| self.town_or_city = nil | |||
| self.postcode_full = nil | |||
| self.postcode_known = nil if lettings? | |||
| self.pcodenk = nil if sales? | |||
There was a problem hiding this comment.
I'm struggling to get a unit test which actually isolates the problem here - suggest we try and merge this anyway (with manual testing) and I'll look at putting one in separately.
kosiakkatrina
approved these changes
Jan 22, 2025
RachaelBooth
added a commit
that referenced
this pull request
Jan 23, 2025
RachaelBooth
added a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.