Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Q5 (ownershipsch) question and hint text #2904

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Changes to Q5 (ownershipsch) question and hint text #2904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3455ea
Changes to Q5 (ownershipsch) question and hint text
Paige-Robbins Jan 16, 2025
cbe9e59
Marked hint text for removal Q5
Paige-Robbins Jan 17, 2025
4f3c1d3
Update question option text
kosiakkatrina Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/form/sales/questions/ownership_scheme.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ def initialize(id, hsh, page)
def answer_options
if form.start_year_2025_or_later?
{
"1" => { "value" => "Yes - a shared ownership scheme", "hint" => "When the purchaser buys an initial share of up to 75% of the property value and pays rent to the Private Registered Provider (PRP) on the remaining portion, or a subsequent staircasing transaction" },
"2" => { "value" => "Yes - a discounted ownership scheme" },
"1" => { "value" => "Shared Ownership", "hint" => "When the purchaser buys an initial share of up to 75% of the property value and pays rent to the Private Registered Provider (PRP) on the remaining portion, or a subsequent staircasing transaction" },
"2" => { "value" => "Discounted Ownership" },
}.freeze
elsif form.start_year_2024_or_later?
{
Expand Down
4 changes: 2 additions & 2 deletions config/locales/forms/2025/sales/setup.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ en:
ownershipsch:
page_header: ""
check_answer_label: "Purchase made under ownership scheme"
hint_text: ""
question_text: "Was this purchase made through an ownership scheme?"
hint_text: "Sales logs are no longer required for outright and other sales FROM 1 APRIL 2025" #Remove this hint text for 2026
question_text: "Is this a shared ownership or a discounted ownership sale?"

staircasing:
page_header: ""
Expand Down
4 changes: 2 additions & 2 deletions spec/models/form/sales/questions/ownership_scheme_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@

it "has the correct answer_options" do
expect(question.answer_options).to eq({
"1" => { "value" => "Yes - a shared ownership scheme", "hint" => "When the purchaser buys an initial share of up to 75% of the property value and pays rent to the Private Registered Provider (PRP) on the remaining portion, or a subsequent staircasing transaction" },
"2" => { "value" => "Yes - a discounted ownership scheme" },
"1" => { "value" => "Shared Ownership", "hint" => "When the purchaser buys an initial share of up to 75% of the property value and pays rent to the Private Registered Provider (PRP) on the remaining portion, or a subsequent staircasing transaction" },
"2" => { "value" => "Discounted Ownership" },
})
end
end
Expand Down
Loading