-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDC-3730 Update tasklist styling #2822
Conversation
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2822 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth adding padding to the task list item on the left and right; removing the underline of the link and/or making on the entire hoverable area the cursor change to a pointer like a button.
Since we've got the entire task list area changing colour on hover now, I don't think we need to keep the link hover behaviour (at least not the underline). I wasn't able to get the cursor pointer to show up in the screen grabs above but it is possible to change it to a hand when hovering over the area.
@Dinssa In terms of the padding I think it should be the same as the component here, but let me know if it deviates from it: https://govuk-components.netlify.app/components/task-list/#input-erb-task-list-with-hints And I think the hover state shows up for me (at least locally) I wonder if it's because our review apps don't get all the styling sometimes due to how our css gets compiled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! That's fair enough this matches what they recommended.
Use govuk classes for tasklists styling