Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDC-3730 Update tasklist styling #2822

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

kosiakkatrina
Copy link
Collaborator

@kosiakkatrina kosiakkatrina commented Nov 26, 2024

Use govuk classes for tasklists styling
image

Copy link

Copy link
Contributor

@Dinssa Dinssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding padding to the task list item on the left and right; removing the underline of the link and/or making on the entire hoverable area the cursor change to a pointer like a button.

hovergif

hover2fig

Since we've got the entire task list area changing colour on hover now, I don't think we need to keep the link hover behaviour (at least not the underline). I wasn't able to get the cursor pointer to show up in the screen grabs above but it is possible to change it to a hand when hovering over the area.

@kosiakkatrina
Copy link
Collaborator Author

Do you think it's worth adding padding to the task list item on the left and right; removing the underline of the link and/or making on the entire hoverable area the cursor change to a pointer like a button.

hovergif hovergif

hover2fig hover2fig

Since we've got the entire task list area changing colour on hover now, I don't think we need to keep the link hover behaviour (at least not the underline). I wasn't able to get the cursor pointer to show up in the screen grabs above but it is possible to change it to a hand when hovering over the area.

@Dinssa In terms of the padding I think it should be the same as the component here, but let me know if it deviates from it: https://govuk-components.netlify.app/components/task-list/#input-erb-task-list-with-hints

And I think the hover state shows up for me (at least locally) I wonder if it's because our review apps don't get all the styling sometimes due to how our css gets compiled

Copy link
Contributor

@Dinssa Dinssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! That's fair enough this matches what they recommended.

@kosiakkatrina kosiakkatrina added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit baf12a1 Nov 28, 2024
16 checks passed
@kosiakkatrina kosiakkatrina deleted the CLDC-3730-update-tasklist-styling branch November 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants