Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block sections without feedback #238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

albertkol
Copy link
Contributor

@albertkol albertkol commented Feb 10, 2025

This PR does two things:

  • fixes a bug:
    • if you are a user that received feedback
    • and you click on the section with feedback and at the end mark it NOT complete
    • it will update the application's status as CHANGES REQUESTED
    • it should stay In Progress
  • blocks all sections that did not receive CHANGE REQUESTS on a re-submission

How to test?

  • create and submit an Application
  • go to assess and make Change Requests on that application
  • go to Apply, you will notice ALL sections that did not receive feedback show only text, rather than link
  • click on the section that received Change Requests, and reach the Summary page
  • click mark section NOT COMPLETE
  • application overall status is still In Progress

Copy link
Contributor

@israr-ulhaq israr-ulhaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants