Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS-4952 : delete endpoints for grants and applications #275

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

FS-4952 : delete endpoints for grants and applications #275

wants to merge 6 commits into from

Conversation

nuwan-samarasinghe
Copy link
Contributor

@nuwan-samarasinghe nuwan-samarasinghe commented Feb 5, 2025 •
edited
Loading

Ticket : https://mhclgdigital.atlassian.net/browse/FS-4952

Change description

Backend changes to delete grants and applications

  1. Delete grants
  2. Delete applications
  3. Adding feature gate to disable some features
  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

@nuwan-samarasinghe nuwan-samarasinghe marked this pull request as ready for review February 6, 2025 15:27
@nuwan-samarasinghe nuwan-samarasinghe enabled auto-merge (squash) February 7, 2025 10:34
@samuelhwilliams
Copy link
Contributor

As discussed on slack, we haven't talked about any feature flagging system so let's remove that from this please. Isn't needed for this functionality. 👍

@nuwan-samarasinghe nuwan-samarasinghe changed the title delete endpoints for grants and applications FS-4952 : delete endpoints for grants and applications Feb 7, 2025
@nuwan-samarasinghe
delete endpoints for grants and applications
50a6194
@nuwan-samarasinghe
adding feature flagged delete changes
1ab7ca2
@nuwan-samarasinghe
adding delete unit tests
6e9bfc3 
adding delete unit tests

adding delete unit tests
@nuwan-samarasinghe
addressing review comments
d5923cc 
addressing review comments

addressing review comments

addressing review comments

addressing review comments
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelhwilliams samuelhwilliams samuelhwilliams left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuwan-samarasinghe @samuelhwilliams