FS-5006: improvements for the all questions pages

[nuwan-samarasinghe]

Ticket: https://mhclgdigital.atlassian.net/browse/FS-5005

Change description

In this PR we have mostly focused on following changes

1. remove numbered references and give textual representation
2. remove hard number system
3. simplify html generation for more readability

• Unit tests and other appropriate tests added or updated
• README and other documentation has been updated / added (if needed)
• Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

Templates's Questions View

Application build question view

All questions page view

[MarcUsher]

Nice work Nuwan! Based on our discussion yesterday I know we said we're only doing minimal tweaks to these views for MVP as it's not crucial but just a few points below as design-wise we've still got a few discrepancies between each of the places that renders viewing questions (the first two I think are using the same method to render so changes to one should go to both). It might be nice to at least make these all consistent:

Build application > View all application questions

• missing the navigation (see designs)
• the xl header for an h1 seems a bit overkill (but I guess we need it to differentiate with the L, M and S further down the page)?

Build application > View questions (for single template)

• missing the navigation (see designs)
• the xl header for an h1 seems a bit overkill (but I guess we need it to differentiate with the L, M and S further down the page)?
• the field types seem to be showing on this view but no others
• this view is essentially the same as the one below (letting the user view questions of a single template) but the design of both pages is quite different eg. here we have a table of contents when it's just one template, which doesn't seem necessary? Also header styles, the [Preview], potentially missing the 'This template contains the following questions."

Template details > view quesitons

• this one most closely matches Mika's intended design so is maybe the pattern to follow for the others (except for the 'view all application questions' still including the table of contents which everyone agreed was a helpful thing?)
• however the section breaks are full-width where the others are not (and also not on the designs)

I think the first govuk-section-break above each section could also maybe be dropped, as I think that's causing the double section break we see on the 'View all application questions' page?

[nuwan-samarasinghe]

As per the discussion had with @MarcUsher we are going to do the changes as much as we can

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud