FS-5006 remove project name field and give default value and fixes for date fields #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
cd77db4 to
f634335
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
f634335 to
52025ec
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
52025ec to
e2c691d
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
e2c691d to
d9d7e58
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
d9d7e58 to
b8b571c
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
MarcUsher
previously approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Approving, nice one Nuwan! Before merging/handover can you make sure to speak to Albert and the Live Services devs so they know that this is now a default value in the FAB exports and what the value refers to/what the other potential values there were when they're importing the configs to Apply so they can change it if needed? We don't want this change to get lost in the handover.
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
b8b571c to
3dcbe16
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
MarcUsher
dismissed
their stale review
Dismissing review until the discussion with Live Services is resolved so we don't merge this by accident.
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
3dcbe16 to
fec861e
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
fec861e to
8659ea2
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
…r date fields # Conflicts: # app/blueprints/round/templates/round_details.html
nuwan-samarasinghe
force-pushed
the
FS-5006-project-id-date-ref
branch
from
8659ea2 to
f9f3651
Compare
nuwan-samarasinghe
temporarily deployed
to
Dev
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://mhclgdigital.atlassian.net/browse/FS-5006
Change description
remove project name field and give default value and fixes for date fields