This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
FS-4355: Dynamically set file url on open method #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwan-samarasinghe
previously approved these changes
May 7, 2024
|
Need to bump the version on this once all the other pending PRs are merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The component was designed to handle both single and multiple files but wasn’t properly tested with multiple files until HSRA. We found that the accept method was setting a global URL for every individual file upload, leading to race conditions where multiple files sometimes shared the same pre-signed URL.
The fix now assigns a unique upload URL directly to each file instead of using a global URL, solving this issue. We’ve also customized the XMLHttpRequest to use the unique URL for each file's upload if available, falling back to the default URL otherwise. This approach prevents the race conditions and ensures each file has its own upload URL.