Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

FS-4306 - Fix for welsh form values being wrong #504

Merged
merged 2 commits into from
Mar 21, 2024
Merged

FS-4306 - Fix for welsh form values being wrong #504

merged 2 commits into from
Mar 21, 2024

Conversation

adamdavies1
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.

  • Welsh forms will no submit correct values fixing the extract file
    image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

Before PR's can be merged they will need to be tested by QA and approved where
applicable. To flag the change to QA assign @XGovFormBuilder/qa as one of the reviewers.

  • Test a welsh application

Checklist:

  • My changes do not introduce any new linting errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased onto main and there are no code conflicts
  • I have checked deployments are working in all environments
  • I have updated the architecture diagrams as per Contribute.md

@tferns tferns changed the title HS_4306 - Fix for welsh form values being wrong FS-4306 - Fix for welsh form values being wrong Mar 21, 2024
Copy link

@tferns tferns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but is there any co-dependent conditional logic in assessment depending on these values? might be worth doing a search on the english values just to make sure theres no coupled logic somewhere

@adamdavies1 adamdavies1 merged commit c6a262f into main Mar 21, 2024
4 of 5 checks passed
@adamdavies1 adamdavies1 deleted the FS-4306 branch March 21, 2024 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants