Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-1374 Add welcome message for new internal users #192

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DT-1374 Add welcome message for new internal users #192

wants to merge 2 commits into from

Conversation

OliviaKRose
Copy link
Collaborator

@OliviaKRose OliviaKRose commented Feb 7, 2025 •
edited
Loading

Description
Added check to see if a user is new by check the audit logs to see how many times they have logged in. This is then passed to Delta

Local testing
Tested locally
Unit tests in progress

Release
Also requires Delta release

hugh-emerson
hugh-emerson reviewed Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@hugh-emerson hugh-emerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there a relevant test to update?

You also need to get the pipeline passing. Is that why it's a draft PR?

@OliviaKRose
Copy link
Collaborator Author

LGTM, but is there a relevant test to update?

You also need to get the pipeline passing. Is that why it's a draft PR?

Yes, it's in draft as I'm still working on the tests plus I need to get the pipeline passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugh-emerson hugh-emerson hugh-emerson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OliviaKRose @hugh-emerson