ENH: Add method to import selected files into DICOM browser #914
+161
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, it is necessary to load individual files and not an entire folder into the DICOM database.
jcfr
reviewed
May 29, 2020
There was a problem hiding this comment.
Looks good 👍
Bonus: Add a simple test to https://github.com/commontk/CTK/blob/9765f24a4a10f4c7f296dc5749f092c2a56c2304/Libs/DICOM/Widgets/Testing/Cpp/ctkDICOMBrowserTest.cpp
Enforce DICOM database file is immediately closed when ctkDICOMDatabase object is destructed. Ensure that images can be inserted after database cleanup. Removed progress popup updates in ctkDICOMAppWidget as it would crash and unnecessary, since browser widget displays progress of background image import. Removed remnants of old progress reporting from ctkDICOMBrowser.
Now all *DICOM* tests pass. DICOM tests require setting of CTKData_DIR and DCMTK executables must be available in a CMakeExternals\Install\bin subfolder of any of the parent folders from where the test is executed.
|
Merci 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it is necessary to load individual files and not an entire folder into the DICOM database.