ENH: Expose ctkPythonConsoleCompleter on the public CTK API #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having ctkPythonConsoleCompleter class available on the public API allows applications to create custom completer implementations derived from this class. For example, this is used in 3D Slicer to get completions with temporarily disabled logging during querying object properties. Temporary suppression of logging is needed because querying object properties leads to executing property getter methods in PythonQt objects. These getter methods may log errors/warnings because the method is deprecated or some inputs in the object have not been set yet. See Slicer/Slicer#6785. fixes commontk#1054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having ctkPythonConsoleCompleter class available on the public API allows applications to create custom completer implementations derived from this class.
For example, this is used in 3D Slicer to get completions with temporarily disabled logging during querying object properties. Temporary suppression of logging is needed because querying object properties leads to executing property getter methods in PythonQt objects. These getter methods may log errors/warnings because the method is deprecated or some inputs in the object have not been set yet. See Slicer/Slicer#6785.
fixes #1054