ENH: Improve error log model API to allow log display in console #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow applications to capture all log messages from the error log model (messages can be injected by calling `postEntry`; and captured by using the new `entryAdded` signal) and display them in the console. - Added `postEntry` method to log events directly, without going through a message handler, but using the same connection mechanism as message handlers (to ensure logging of messages in the correct order). - Added `entryAdded` signal that provides full log entry information (not just the log level as the existing signal). This can be used for displaying log messages in an additional widget, such as the Python console. - Modified ctkConsole's command execution method to allow displaying messages that are logged during execution before showing the next command prompt.
lassoan
force-pushed
the
get-log-msg-handler-api
branch
from
2498655 to
a0d8362
Compare
jcfr
approved these changes
Oct 14, 2022
|
Nitpick: To prevent future regression, updating |
|
Thanks for the review I may add tests later. |
pieper
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow applications to capture all log messages from the error log model (messages can be injected by calling
postEntry; and captured by using the newentryAddedsignal) and display them in the console. See for example: Slicer/Slicer#5156 (comment)postEntrymethod to log events directly, without going through a message handler, but using the same connection mechanism as message handlers (to ensure logging of messages in the correct order).entryAddedsignal that provides full log entry information (not just the log level as the existing signal). This can be used for displaying log messages in an additional widget, such as the Python console.