ENH: Add API to get message handler from ctkErrorLogAbstractModel #1043
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
force-pushed
the
get-log-msg-handler-api
branch
2 times, most recently
from
a5d67b3 to
af815c0
Compare
jcfr
reviewed
Oct 13, 2022
Libs/Core/ctkErrorLogAbstractModel.h
Outdated
|
|
||
| QStringList msgHandlerNames()const; | ||
| Q_INVOKABLE QStringList msgHandlerNames()const; |
There was a problem hiding this comment.
Instead of specifying Q_INVOKABLE, I suggest to specify this:
Q_PROPERTY(QStringList msgHandlerNames READ msgHandlerNames)
This will allow to use model.msgHandlerNames from python
There was a problem hiding this comment.
Q_PROPERTY(QStringList msgHandlerNames READ msgHandlerNames)
Done.
This API is useful for accessing message handlers, for example to connect to messageHandled signals.
lassoan
force-pushed
the
get-log-msg-handler-api
branch
from
af815c0 to
dd002cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is useful for accessing message handlers, for example to connect to messageHandled signals.