-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix unit tests for #5262 ("Remove location" button for new uploads) #5337
Feature/fix unit tests for #5262 ("Remove location" button for new uploads) #5337
Conversation
…ocation picker from upload wizard.
…nt. Linked to empty onClickRemoveLocation method.
…. Linked to empty removeLocationFromPicture() method.
…ndroid-commons into feature/fix-unit-tests
Thanks a lot for fixing the unit tests! I just performed more real-world tests, and realized latitude/longitude are not actually removed from the EXIF of the picture. Hopefully this will be fixed soon and I will be able to merge. :-) |
@nicolas-raoul - Do you mind adding the hacktoberfet-accepted label? |
I added the label. |
@nicolas-raoul - Can you elaborate on what the statement you made means:
What exactly did you try and what exactly did you see (and how)? Thanks |
Sure! |
Please do not hesitate to comment at #5262 (comment) 🙂 |
Description (required)
#5262 introduces a useful feature, but makes two unit tests fail.
The two units tests that are failing are:
Fixes #5291
What changes did you make and why?
Added a variable to mock the newly added removeLocationButton
Tests performed (required)
Tested unit tests on an emulated device with API level 29
Screenshots (for UI changes only)
N/A