5195: Fix upload wizard crash on tapping target icon #5306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th no EXIF location
nicolas-raoul
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
I tried this pull request on all places in the app where there is a map (after removing location permission ad restarting the app each time), no crash. :-)
I observed a less severe bug so I will merge this and let's keep track of the less severe bug here: #5309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5195
What changes did you make and why?
Added a null check to prevent the app from crashing when location updates aren't available.
Tests performed (required)
Tested prodDebug on Redmi 5A with API level 27.