Fixes in-app camera behaviour #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test on API level 12? The |
|
Tested it on my Android 8.1 device. I think this error is happening only for the PS: Sorry for assuming that both the flavours behave in the same way and the upload would fail on the prod flavour too. I ended up uploading a test image on the prod flavour. Might be taken up as a separate issue later; I'm still facing issues on the beta flavour. |
|
On Android 14 with this pull request, I unfortunately still see the issue (all 4 symptoms listed at the end of #5300 reproduce every time). The Wikidata and OkHttp lines can probably be ignored, I guess they happen in the background. It is interesting to see that the app manages to parse the picture's EXIF: If I use the "Fake GPS" app to pretend I am in Costa Rica, the log line towards the middle says |
|
@RitikaPahwa4444 Tested the build on api 23 as well, works well for me. Also, the sign up screen crashes for API 21, need to update jdk version and 2 dependencies, can be fixed as part of separate issue here. |
Do we have a |
@RitikaPahwa4444 I meant compile and target SDK above. Sry for the confusion. |
|
I am running the app on Android 14, but I compiled it without modifying any file, meaning with compileSdkVersion=targetSdkVersion=33. |
@nicolas-raoul Tested this on API 34 (emulator) as well, works well for me, env was prodDebug.
|
|
Thanks for testing! |
if you could try running on some other device with android 14 that would be great, on my end I can try on this device. If everything works for me, idk how to debug the issue you are facing. The logs above don't seem to be of any help. Also, can you make sure that the issue you are facing is not something permission related, you can copy paste this one liner code to main where the code for #5299 was merged and try running. |
|
Somehow the upload failure does not seem to happen today, on the same Pixel 7 Pro device. 🤯 Accordingly, I am in favor of merging this. 🙂 |
nicolas-raoul
approved these changes
Sep 25, 2023
I tested on a OnePlus Nord running Android 12 and observe the minor issues, too. I opened issue #5305 to track this. |
@sivaraam @nicolas-raoul I was not able to replicate the issue mentioned in #5305 on both emulator and a device, so maybe someone else can take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5300
What changes did you make and why?
The toast for
file not found, try another filedoes not appear now. The camera picture seems to upload for me but sometimes due to an API error as below it (any picture from this app) never completely uploads for me.The API error is here, maybe indicates some limit on API usage:
Maybe someone else should try on their device.
Tests performed (required)
Tested {Debug} on {samsung galaxy M31} with API level {12}.
Screenshots (for UI changes only)
2023_09_24_08_43_00_trim.mp4
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.