Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #4469 selecting text doesn't always work in upload wizard #4520

Merged

Conversation

benryder1988
Copy link
Contributor

Description (required)

Fixes #4469

What changes did you make and why?

  • Removed the initial setText calls for the caption and description editText fields, since they seem to unneeded and set later on lines 148 and 152. This seems to have fixed the issue, where text was not selectable (and therefore copyable) when a user click the 'next' button and then returned to the screen with the caption and description.

Tests performed (required)

  • Opened app and started upload wizard, after taking a picture and adding a caption and description
  • Tested that selecting the text still works before pressing 'next'
  • Clicked 'next' and then 'previous' and then confirmed that the text could now selected as expected
  • Tested progressing to and then back from multiple steps during upload process (after adding 'depicts' and 'categories' etc.)
  • Tested an upload with the change, the caption and description working as expected
  • Tested ProdBeta on Google Pixel 4a (5G) with API level 30 (Android Version 11)

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benryder1988 !:)

@neslihanturan
Copy link
Collaborator

And thanks for nicely written PR too :)

@neslihanturan neslihanturan merged commit a94a28f into commons-app:master Aug 6, 2021
@nicolas-raoul
Copy link
Member

@benryder1988 This commit unfortunately broke the "Copy to subsequent media" feature. Would you mind checking? Thanks! :-)

nicolas-raoul added a commit that referenced this pull request Aug 14, 2021
@nicolas-raoul
Copy link
Member

This commit also unfortunately breaks the feature that auto-fills the caption of pictures uploaded via Nearby.
I reverted it for now, but looking forward to a new pull request as fixing the test selection bug would be really nice :-) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes can't copy/paste from/to Upload caption field
3 participants