Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWLProv: add directory basename to the provenance metadata #1798

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

simleo
Copy link
Contributor

@simleo simleo commented Feb 2, 2023

Changes the code to add a "cwlprov:basename" entry for directories (currently it is only added for files).

This is needed to support reproducibility when directories need to follow a naming pattern (e.g., from secondaryFiles).

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #1798 (42303f9) into main (68fd957) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   83.49%   83.48%   -0.01%     
==========================================
  Files          44       44              
  Lines        8100     8102       +2     
  Branches     2217     2218       +1     
==========================================
+ Hits         6763     6764       +1     
  Misses        855      855              
- Partials      482      483       +1     
Impacted Files Coverage Δ
cwltool/provenance_profile.py 74.01% <50.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mr-c mr-c merged commit 9c1b525 into common-workflow-language:main Feb 2, 2023
@mr-c
Copy link
Member

mr-c commented Feb 2, 2023

Thank you @simleo ! What is the urgency level to get this released?

@simleo simleo deleted the cwlprov_dir_basename branch February 3, 2023 14:08
@simleo
Copy link
Contributor Author

simleo commented Feb 3, 2023

@mr-c In theory the RO bundle could be regenerated with cwltool installed from the main branch, but it would be better to be able to point to a release. I see there's been a release right before this PR. Would another release in a week or so be ok?

@mr-c
Copy link
Member

mr-c commented Feb 3, 2023

I'll release again next week, no problem. Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants